Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Sm/linked-plugin-compile #517

Merged
merged 13 commits into from
Jan 6, 2023
Merged

Sm/linked-plugin-compile #517

merged 13 commits into from
Jan 6, 2023

Conversation

mshanemc
Copy link
Member

@mshanemc mshanemc commented Dec 16, 2022

during plugin:link, if it looks like a TS plugin, we'll add a compilation step.

This looks at devDeps to detect TS. not only is that a decent proxy for "is it written in TS" but it also lets use safely compile via tsc because the devDep includes that.

fix forcedotcom/cli#1664

this does not fix the issues of ts plugins not recompiling on each run, or oclif using the compiled code for linked plugins instead of the source

QA ideas:
clone this, switch this branch, then you can link plugin-plugins into your cli sfdx plugins:link .

so that you get something like

sfdx plugins
@oclif/plugin-plugins 2.1.7 (link) /Users/shane.mclaughlin/eng/oclif-repos/plugin-plugins

Then you can link any other plugin you have locally. If you delete the lib folder, when you run the link command, it should be recreated for you.

@W-11731121@

Copy link
Contributor

@RodEsp RodEsp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good except for the settings file.

.vscode/settings.json Outdated Show resolved Hide resolved
@mshanemc mshanemc requested a review from RodEsp January 5, 2023 16:50
src/plugins.ts Outdated Show resolved Hide resolved
src/plugins.ts Outdated Show resolved Hide resolved
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Plugin got broken after CLI update
2 participants