Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: aliases support #331

Merged
merged 1 commit into from
May 3, 2022
Merged

feat: aliases support #331

merged 1 commit into from
May 3, 2022

Conversation

jrmncos
Copy link
Contributor

@jrmncos jrmncos commented Apr 18, 2022

Hi team! Thanks for the great plugin!
I need the approval of this PR 🙏🏽

If a command with a topic has an alias the autocomplete doesn't show it

some-cli/
   src/
      commands/
         some-topic/
            my-awesome-command
class MyAwesomeCommand extends Command {
    static alias = ['my-awesome-command']
    ...
}

Previous behavior:
some-cli TAB TAB => some-topic

Actual behavior:
some-cli TAB TAB => some-topic and my-awesome-command

Thanks a lot!

@salesforce-cla
Copy link

Thanks for the contribution! Before we can merge this, we need @jrmncos to sign the Salesforce.com Contributor License Agreement.

Copy link
Contributor

@RodEsp RodEsp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Overall looks good to me.

@RasPhilCo since this is pretty simple functionality would you happen to know why it wasn't added from the get-go? Maybe there's a good reason we don't want this that I'm overlooking?

@RodEsp RodEsp requested a review from RasPhilCo April 19, 2022 14:36
@RodEsp
Copy link
Contributor

RodEsp commented May 3, 2022

Sync'ed with @RasPhilCo on this in Slack.
image

I don't think there should be a problem merging this.

@RodEsp RodEsp merged commit c7b1ef3 into oclif:main May 3, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants