fix: print valid flag values in error message when using exactlyOne (…

…#232)
oclif · Feb 25, 2022 · 7b348f8 · 7b348f8
1 parent 5cc8ba1
commit 7b348f8
Show file tree

Hide file tree

Showing 2 changed files with 5 additions and 5 deletions.
diff --git a/src/validate.ts b/src/validate.ts
@@ -53,8 +53,8 @@ export function validate(parse: {
     if (intersection.length === 0) {
       // the command's exactlyOne may or may not include itself, so we'll use Set to add + de-dupe
       throw new CLIError(`Exactly one of the following must be provided: ${[
-        ...new Set(...flag.exactlyOne || [], flag.name),
-      ].join(',')}`)
+        ...new Set(flag.exactlyOne?.map(flag => `--${flag}`)),
+      ].join(', ')}`)
     }
   }
 

diff --git a/test/parse.test.ts b/test/parse.test.ts
@@ -719,11 +719,11 @@ See more help with --help`)
       expect(() => {
         parse([], {
           flags: {
-            foo: flags.string({exactlyOne: ['bar']}),
-            bar: flags.string({char: 'b', exactlyOne: ['foo']}),
+            foo: flags.string({exactlyOne: ['bar', 'foo']}),
+            bar: flags.string({char: 'b', exactlyOne: ['bar', 'foo']}),
           },
         })
-      }).to.throw()
+      }).to.throw('Exactly one of the following must be provided: --bar, --foo')
     })
 
     it('throws if multiple are set', () => {