Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: dont assume plugin-help is installed #975

Merged
merged 1 commit into from
Feb 26, 2024
Merged

Conversation

mdonnalley
Copy link
Contributor

Use Help class directly instead of assuming that plugin-help is installed.

QA

  • pull branch, yarn && yarn build
  • oclif generate my-cli
  • Remove all references to plugin-help from my-cli's package.json
  • Remove src/hello/index.ts
  • yarn link @oclif/core in my-cli directly
  • Run bin/dev.js hello - you should see help output for the hello topic

Fixes #848
@W-15103728@

@shetzel
Copy link
Contributor

shetzel commented Feb 26, 2024

QA:
Followed the steps above and saw the expected output.

bin/dev.js hello
Say hello to the world and others

USAGE
  $ my-cli hello COMMAND

COMMANDS
  hello world  Say hello world

@shetzel shetzel merged commit 8cf6828 into main Feb 26, 2024
62 checks passed
@shetzel shetzel deleted the mdonnalley/use-help-class branch February 26, 2024 23:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

improve topic help resolution if @oclif/plugin-help isn't available as a plugin
2 participants