fix: revert to original prompt implementation #968
Conversation
| @@ -153,7 +154,7 @@ jobs: | |||
| with: | |||
| repo: oclif/plugin-plugins | |||
| os: ${{ matrix.os }} | |||
| command: 'yarn test:integration' | |||
| command: yarn test:integration --retries 3 | |||
There was a problem hiding this comment.
suggestion: external-test could use the normal retries code
salesforcecli/github-workflows/.github/actions/retry instead of all of its consumers need to do this
There was a problem hiding this comment.
Hm, actually. I don't think this will work since external-test.yml uses working-directory. An external action (uses) needs to support passing it in, which the retry action we use does not https://github.com/nick-fields/retry
There was a problem hiding this comment.
@iowillhoit @mshanemc I don't think we can use the retry action since you need to be able to set the working_directory, which as far as I can tell isn't possible with that action
Looks like Eric beat me to it 😄
There was a problem hiding this comment.
haha exactly 😅 We were both looking at this at the same time ^
Revert the change made to
ux.promptby #953This change resolved the bug reported in #952 but introduced other issues involving the prompt not timing in non-TTY environments. Since we plan to remove (or greatly reduce the functionality of) the
uxmodule in the next major version, we're going to live with #952 for now. If people want a better prompt, then can switch to a dedicated library like inquirer.