fix: command not found on empty arg (#887) #888
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
when `topicSeparator` is a space and an empty string arg is given,
the searched command ID had an extra colon:
example:
```bash
set FOO=""
cli cmd ${FOO} --bar
```
result: command not found "cmd"
root cause: incorrect parsing in `standardizeIDFromArgv`,
which for the above example returned `cmd:` as the command ID.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Merges #887
when
topicSeparatoris a space and an empty string arg is given, the searched command ID had an extra colon:example:
result: command not found "cmd"
root cause: incorrect parsing in
standardizeIDFromArgv, which for the above example returnedcmd:as the command ID.