-
Notifications
You must be signed in to change notification settings - Fork 73
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: various fixes #824
feat: various fixes #824
Conversation
This issue has been linked to a new work item: W-14284744 |
src/config/ts-node.ts
Outdated
if (!rootDirPath || !outDir) return orig | ||
debug(`determining path for ${orig}`) | ||
const {baseUrl, outDir, rootDir, rootDirs} = tsconfig.compilerOptions | ||
const rootDirPath = rootDir || (rootDirs || [])[0] || baseUrl |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
should these be ??
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'll update it
QA Notesfollowing QA docs in PR ✅ : |
Support
.mts
and.cts
file extensions (Fixes Supportmts
andcts
file extensions which typescript nightly builds support usingcompilerOptions.module = "nodenext"
#362).cts
:git clone https://github.com/oclif/hello-world
yarn link @oclif/core
hello.ts
tohello.cts
bin/dev.js hello oclif --from me
yarn tsc && bin/run.js hello oclif --from me
.mts
:git clone https://github.com/oclif/hello-world-esm
yarn link @oclif/core
hello.ts
tohello.mts
bin/dev.js hello oclif --from me
yarn tsc && bin/run.js hello oclif --from me
Support
baseUrl
for configuring source directory (Fixes Missingtsconfig.json:compilerOptions.rootDir
makes dev-mode load commands from./dist/
#716)git clone https://github.com/oclif/hello-world
yarn link @oclif/core
rootDir
from tsconfig and replace withbaseUrl: "./src"
bin/dev.js hello oclif --from me
Bump ejs and other deps (Closes fix(deps): bump ejs and @types/ejs #821, Closes build(ejs): bump ejs v to 3.1.9 #790)
Parallelize flag and arg caching
Add a
Cache
class for caching the root plugin. This is better than the previous solution, which relied on the root plugin being processed bytsPath
, which won't happen if the root plugin does not contain any commands