Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: various fixes #824

Merged
merged 8 commits into from
Oct 13, 2023
Merged

feat: various fixes #824

merged 8 commits into from
Oct 13, 2023

Conversation

mdonnalley
Copy link
Contributor

@mdonnalley mdonnalley commented Oct 12, 2023

@mdonnalley mdonnalley added the enhancement New feature or request label Oct 12, 2023
@git2gus
Copy link

git2gus bot commented Oct 12, 2023

This issue has been linked to a new work item: W-14284744

WillieRuemmele
WillieRuemmele previously approved these changes Oct 13, 2023
if (!rootDirPath || !outDir) return orig
debug(`determining path for ${orig}`)
const {baseUrl, outDir, rootDir, rootDirs} = tsconfig.compilerOptions
const rootDirPath = rootDir || (rootDirs || [])[0] || baseUrl
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

should these be ??

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'll update it

@WillieRuemmele
Copy link
Contributor

QA Notes


following QA docs in PR

✅ : cts conversion
✅ : mts conversion
✅ : baseUrl tsconfig option
✅ : caching passed by passing other QA

@WillieRuemmele WillieRuemmele merged commit 2d1590d into main Oct 13, 2023
34 checks passed
@WillieRuemmele WillieRuemmele deleted the mdonnalley/various-fixes branch October 13, 2023 16:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Missing tsconfig.json:compilerOptions.rootDir makes dev-mode load commands from ./dist/
2 participants