test: compilation errors

oclif · Oct 11, 2023 · 0728590 · 0728590
1 parent 5bf0a2e
commit 0728590
Show file tree

Hide file tree

Showing 4 changed files with 10 additions and 3 deletions.
diff --git a/src/util/cache-command.ts b/src/util/cache-command.ts
@@ -87,16 +87,17 @@ export async function cacheCommand(
   const args = await cacheArgs(ensureArgObject(cmd.args), respectNoCacheDefault)
 
   const stdProperties = {
-    aliases: cmd.aliases || [],
+    aliases: cmd.aliases ?? [],
     args,
     deprecateAliases: cmd.deprecateAliases,
     deprecationOptions: cmd.deprecationOptions,
     description: cmd.description,
-    examples: cmd.examples || (cmd as any).example,
+    // Support both `examples` and `example` for backwards compatibility.
+    examples: cmd.examples ?? (cmd as unknown as {example: string}).example,
     flags,
     hasDynamicHelp: Object.values(flags).some((f) => f.hasDynamicHelp),
     hidden: cmd.hidden,
-    hiddenAliases: cmd.hiddenAliases || [],
+    hiddenAliases: cmd.hiddenAliases ?? [],
     id: cmd.id,
     pluginAlias: plugin && plugin.alias,
     pluginName: plugin && plugin.name,

diff --git a/test/config/config.flexible.test.ts b/test/config/config.flexible.test.ts
@@ -58,6 +58,7 @@ describe('Config with flexible taxonomy', () => {
         flagA: Flags.boolean({char: 'a'}),
       },
       hidden: false,
+      hiddenAliases: [],
       id: commandIds[0],
       async load(): Promise<Command.Class> {
         return MyCommandClass
@@ -74,6 +75,7 @@ describe('Config with flexible taxonomy', () => {
         flagB: Flags.boolean({}),
       },
       hidden: false,
+      hiddenAliases: [],
       id: commandIds[1],
       async load(): Promise<Command.Class> {
         return MyCommandClass

diff --git a/test/config/config.test.ts b/test/config/config.test.ts
@@ -251,6 +251,7 @@ describe('Config', () => {
         args: {},
         flags: {},
         hidden: false,
+        hiddenAliases: [],
         id: commandIds[0],
         async load(): Promise<Command.Class> {
           return MyCommandClass
@@ -264,6 +265,7 @@ describe('Config', () => {
         args: {},
         flags: {},
         hidden: false,
+        hiddenAliases: [],
         id: commandIds[1],
         async load(): Promise<Command.Class> {
           return MyCommandClass

diff --git a/test/util/cache-command.test.ts b/test/util/cache-command.test.ts
@@ -59,6 +59,7 @@ describe('cacheCommand', () => {
       state: undefined,
       description: 'test command',
       aliases: ['alias1', 'alias2'],
+      hiddenAliases: [],
       title: 'cmd title',
       usage: ['$ usage'],
       examples: undefined,
@@ -193,6 +194,7 @@ describe('cacheCommand', () => {
       hidden: undefined,
       state: 'beta',
       aliases: ['base'],
+      hiddenAliases: [],
       examples: undefined,
       deprecationOptions: undefined,
       deprecateAliases: undefined,