Skip to content
This repository has been archived by the owner on Aug 22, 2023. It is now read-only.

feat: disable registering of ts-node #69

Merged
merged 1 commit into from
Jan 18, 2019
Merged

feat: disable registering of ts-node #69

merged 1 commit into from
Jan 18, 2019

Conversation

amphro
Copy link
Contributor

@amphro amphro commented Jan 18, 2019

There are some use cases when you would not want oclif to load using ts-node for you, like if you are already running ts-node to run tests or if you want to run off the compiled code. This gives the user the option to disable it if they need to.

There are some use cases when you would not want oclif to load using ts-node for you, like if you are already running ts-node to run tests or if you want to run off the compiled code. This gives the user the option to disable it if they need to.
@amphro amphro requested a review from jdx January 18, 2019 19:05
@codecov
Copy link

codecov bot commented Jan 18, 2019

Codecov Report

Merging #69 into master will decrease coverage by 0.15%.
The diff coverage is 0%.

Impacted file tree graph

@@            Coverage Diff            @@
##           master     #69      +/-   ##
=========================================
- Coverage   68.76%   68.6%   -0.16%     
=========================================
  Files           7       7              
  Lines         429     430       +1     
  Branches      119     120       +1     
=========================================
  Hits          295     295              
  Misses         87      87              
- Partials       47      48       +1
Impacted Files Coverage Δ
src/ts-node.ts 82% <0%> (-1.68%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a67ce2b...1ee5035. Read the comment docs.

2 similar comments
@codecov
Copy link

codecov bot commented Jan 18, 2019

Codecov Report

Merging #69 into master will decrease coverage by 0.15%.
The diff coverage is 0%.

Impacted file tree graph

@@            Coverage Diff            @@
##           master     #69      +/-   ##
=========================================
- Coverage   68.76%   68.6%   -0.16%     
=========================================
  Files           7       7              
  Lines         429     430       +1     
  Branches      119     120       +1     
=========================================
  Hits          295     295              
  Misses         87      87              
- Partials       47      48       +1
Impacted Files Coverage Δ
src/ts-node.ts 82% <0%> (-1.68%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a67ce2b...1ee5035. Read the comment docs.

@codecov
Copy link

codecov bot commented Jan 18, 2019

Codecov Report

Merging #69 into master will decrease coverage by 0.15%.
The diff coverage is 0%.

Impacted file tree graph

@@            Coverage Diff            @@
##           master     #69      +/-   ##
=========================================
- Coverage   68.76%   68.6%   -0.16%     
=========================================
  Files           7       7              
  Lines         429     430       +1     
  Branches      119     120       +1     
=========================================
  Hits          295     295              
  Misses         87      87              
- Partials       47      48       +1
Impacted Files Coverage Δ
src/ts-node.ts 82% <0%> (-1.68%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a67ce2b...1ee5035. Read the comment docs.

@jdx
Copy link
Contributor

jdx commented Jan 18, 2019

this is potentially a poor solution for #44

@jdx jdx merged commit 3346db8 into master Jan 18, 2019
@jdx jdx deleted the tsnode branch January 18, 2019 19:16
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants