Skip to content
This repository has been archived by the owner on Aug 22, 2023. It is now read-only.

Add isRunByDefault option to command.run() #100

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

rizzlesauce
Copy link

@codecov
Copy link

codecov bot commented Mar 14, 2020

Codecov Report

Merging #100 into master will decrease coverage by 66.81%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff            @@
##           master   #100       +/-   ##
=========================================
- Coverage   66.81%     0%   -66.82%     
=========================================
  Files           7      2        -5     
  Lines         452     12      -440     
  Branches      127      3      -124     
=========================================
- Hits          302      0      -302     
+ Misses        101     12       -89     
+ Partials       49      0       -49
Impacted Files Coverage Δ
src/index.ts 0% <0%> (-100%) ⬇️
src/debug.ts 0% <0%> (-45.46%) ⬇️
src/ts-node.ts
src/plugin.ts
src/util.ts

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b0c2c9e...744d0a2. Read the comment docs.

@rizzlesauce
Copy link
Author

rizzlesauce commented Mar 15, 2020

I need to add more to this to get to the desired signature of: Command.run({isRunByDefault: boolean}).

EDIT: this is done

@rizzlesauce rizzlesauce force-pushed the feature/is-run-by-default-flag branch from 983988e to 0e3b914 Compare March 16, 2020 11:56
@RasPhilCo
Copy link
Contributor

Thanks for the PR on this @rizzlesauce! I really don't like to not use your efforts, but this particular solution was an edge case that was easier for me to write than explain. Thanks for your patience as well!

See my comment oclif/oclif#277 (comment) on adding a root index command.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants