Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Editable QComboBox without icon is wrongly placed and cropped #63

Open
oclero opened this issue Oct 14, 2024 · 2 comments · Fixed by #66
Open

Editable QComboBox without icon is wrongly placed and cropped #63

oclero opened this issue Oct 14, 2024 · 2 comments · Fixed by #66
Assignees
@oclero
Labels
bug Something isn't working
Milestone
1.0.1

Comments

@oclero
Copy link
Owner

oclero commented Oct 14, 2024

The bug is present on editable QComboBox and its derivatives (QFontComboBox)

cropped
@oclero oclero added the bug Something isn't working label Oct 14, 2024
@oclero oclero added this to the 1.0.0 milestone Oct 14, 2024
oclero added a commit that referenced this issue Nov 1, 2024
@oclero
fix #63 : textfield of QFontComboBox is cropped
9913162
@oclero
Copy link
Owner Author

oclero commented Nov 1, 2024

It should work now.

Capture d'écran 2024-11-01 183427

(Tested on Windows)

@oclero oclero self-assigned this Nov 1, 2024
@oclero oclero mentioned this issue Nov 2, 2024
Merged
@oclero oclero closed this as completed in 25db942 Nov 24, 2024
@christophe-thiery-fw
Copy link
Collaborator

Reopening. The bug happens if the editable combobox has at no icon in its items. You can reproduce it in the showcase window if you remove icons from the editable combobox:
image

Instead of detecting if this is a QFontComboBox, we should detect if there is an icon.

@christophe-thiery-fw christophe-thiery-fw changed the title Editable QComboBox text is wrongly placed and cropped Editable QComboBox text without icon is wrongly placed and cropped Dec 6, 2024
@christophe-thiery-fw christophe-thiery-fw changed the title Editable QComboBox text without icon is wrongly placed and cropped Editable QComboBox without icon is wrongly placed and cropped Dec 6, 2024
@oclero oclero modified the milestones: 1.0.0, 1.1.0, 1.0.1 Dec 11, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@oclero oclero

Labels
bug Something isn't working
Projects
None yet
Milestone
1.0.1
Development

Successfully merging a pull request may close this issue.

Feature/showcase window oclero/qlementine
2 participants
@oclero @christophe-thiery-fw