This repository has been archived by the owner on Oct 2, 2024. It is now read-only.
turing: account for -slack nicks when adding 0-length spaces #91
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kkuehlz
approved these changes
Jan 20, 2019
ircbot/plugin/turing.py
Outdated
| # the end of a nick, to avoid inserting a space like | ||
| # abcde|-slack (thus pinging abcde). | ||
| def insert_space(w): | ||
| halfway = len(re.sub('-slack([^A-Za-z0-9_\\-\\\\\\[\\]{}^`|]|\\Z)', '\\1', w)) // 2 |
There was a problem hiding this comment.
Can we use an r-string to make this more readable?
dkess
reviewed
Jan 21, 2019
| # This is also much simpler than using crazy IRC nick regex. | ||
| # Put it in the middle of the word since nicks are quoted | ||
| # using "<@keur>" syntax. | ||
| # using "<@keur>" syntax. Additionally, remove any -slack at | ||
| # the end of a nick, to avoid inserting a space like |
There was a problem hiding this comment.
Why use the middle? I think it would be better to find where the nick actually starts, and put it after the first letter.
There was a problem hiding this comment.
This is probably a better approach, but it's notably harder. It's not that easy to break the message into each discrete nick.
|
I'm going to merge this. I opened an issue (#100) for handling better 0-length spaces in nicks in general. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
as advertised in #test