Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

change datum default to MSL for coops_product_within_region #90

Merged
merged 5 commits into from
Feb 1, 2024

Conversation

FariborzDaneshvar-NOAA
Copy link
Contributor

No description provided.

@SorooshMani-NOAA
Copy link
Collaborator

@FariborzDaneshvar-NOAA the code in this repo is styled using black. Please install it and format the file you updated. Thank you!

@SorooshMani-NOAA
Copy link
Collaborator

@FariborzDaneshvar-NOAA can you please merge bugfix/test_ref to this branch? The test failure is due to an issue with test reference. The USGS response for a past storm has been updated. I added the updated ref file in that branch, please get the change and see if the test go through. Thanks!

@FariborzDaneshvar-NOAA
Copy link
Contributor Author

@FariborzDaneshvar-NOAA can you please merge bugfix/test_ref to this branch? The test failure is due to an issue with test reference. The USGS response for a past storm has been updated. I added the updated ref file in that branch, please get the change and see if the test go through. Thanks!

@SorooshMani-NOAA I cannot make a pull request to merge bugfix/test_ref to default_coops_datum. Please correct me if I'm wrong, thanks.
image

@FariborzDaneshvar-NOAA
Copy link
Contributor Author

@SorooshMani-NOAA I executed the following commands to merge bugfix/test_ref with default_coops_datum, but got this message: Already up-to-date.

git fetch --all 
git checkout bugfix/test_ref 
git checkout default_coops_datum  
git merge bugfix/test_ref 

Please let me know if there is something I'm missing. thanks

@SorooshMani-NOAA
Copy link
Collaborator

@FariborzDaneshvar-NOAA sorry I realized I hadn't pushed the test ref changes to that branch remote!! Please fetch again and do the same as what you did, you should now get the test update (.csv files). Sorry about that!

@FariborzDaneshvar-NOAA
Copy link
Contributor Author

@SorooshMani-NOAA Thanks!

Fast-forward
tests/data/reference/test_usgs_flood_events/events.csv | 4 ++--
tests/data/reference/test_usgs_flood_storms/storms.csv | 4 ++--
2 files changed, 4 insertions(+), 4 deletions(-)

@SorooshMani-NOAA
Copy link
Collaborator

@pmav99 can you help me figure out what's going on with the CodeCov here? I don't understand why it fails!

@SorooshMani-NOAA
Copy link
Collaborator

@pmav99 I'd appreciate it if you could take a look at this PR too to see why the coverage gets cancelled?

@pmav99
Copy link
Member

pmav99 commented Jan 30, 2024

No idea really. Try to disable the -n auto to see what happens

@SorooshMani-NOAA SorooshMani-NOAA merged commit bf9e36e into main Feb 1, 2024
7 of 9 checks passed
@SorooshMani-NOAA SorooshMani-NOAA deleted the default_coops_datum branch February 1, 2024 20:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants