Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update stormevent.py #88

Closed
wants to merge 1 commit into from
Closed

Conversation

naingeet
Copy link

updating tide datum to 'msl' in function coops_product_within_isotach

updating tide datum to 'msl'  in function coops_product_within_isotach
@naingeet
Copy link
Author

updating tide datum to msl

@SorooshMani-NOAA
Copy link
Collaborator

It makes sense to have some value as the default since in the COOPS API documentation it says (emphasis mine):

Datum is mandatory for all water level products to correct the data to the reference point desired.
Does not apply to Air Gap data, which is only provided relative to a fixed reference point on the bridge.

And most of the times we're interested in water level products.

@naingeet can you please make sure all the test go through? We format the code using black

@SorooshMani-NOAA SorooshMani-NOAA self-assigned this Oct 30, 2023
@SorooshMani-NOAA
Copy link
Collaborator

Since there hasn't been any updates on this request I close it for now

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants