Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

use renamed functions from typepigeon>=2.0.0 #62

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

zacharyburnett
Copy link
Collaborator

@zacharyburnett zacharyburnett commented Feb 28, 2023

Fixes #59

@zacharyburnett zacharyburnett self-assigned this Feb 28, 2023
@zacharyburnett zacharyburnett changed the title use renamed typepigeon functions use renamed typepigeon functions from version >=2.0.0 Feb 28, 2023
@zacharyburnett zacharyburnett changed the title use renamed typepigeon functions from version >=2.0.0 use renamed functions from typepigeon>=2.0.0 Feb 28, 2023
@SorooshMani-NOAA
Copy link
Collaborator

Hi @zacharyburnett thanks for working on this. In the last merge (#60) I made sure all the tests pass (except for the coverage that depends on time of year that your run). Please let me know if you'd like me to contribute to this pull, thanks!

@zacharyburnett
Copy link
Collaborator Author

zacharyburnett commented Feb 28, 2023

No problem! It looks like the test failures are due to using searvey 0.2.1 that used the previous typepigeon API, and the new 0.3.0 release did not successfully upload to PyPI as it didn't pick up the correct version: oceanmodeling/searvey#61

Once that is resolved, this should run fine.

@codecov
Copy link

codecov bot commented Feb 28, 2023

Codecov Report

Attention: Patch coverage is 85.18519% with 4 lines in your changes are missing coverage. Please review.

Project coverage is 91.70%. Comparing base (ee51dd1) to head (5562180).

Files Patch % Lines
stormevents/usgs/events.py 71.42% 2 Missing ⚠️
stormevents/usgs/highwatermarks.py 66.66% 2 Missing ⚠️
Additional details and impacted files
@@           Coverage Diff           @@
##             main      #62   +/-   ##
=======================================
  Coverage   91.70%   91.70%           
=======================================
  Files          19       19           
  Lines        1988     1988           
=======================================
  Hits         1823     1823           
  Misses        165      165           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@SorooshMani-NOAA
Copy link
Collaborator

@zacharyburnett I reran the failed tests after searvey 0.3.1 release and I get patch coverage issues. I think we can safely ignore it, but it's up to you. Just FYI since I merged my build issue pull request, you need to update the branch before merging to mail.

@SorooshMani-NOAA SorooshMani-NOAA marked this pull request as ready for review April 26, 2024 13:27
@SorooshMani-NOAA SorooshMani-NOAA self-assigned this Apr 26, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Fix deprecation issues
2 participants