Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix HWM multi-storm bug for Hurricane Laura [#40] #43

Merged
merged 1 commit into from
Jun 3, 2022

Conversation

zacharyburnett
Copy link
Collaborator

and add pre-commit configuration

@zacharyburnett zacharyburnett self-assigned this Jun 3, 2022
@codecov
Copy link

codecov bot commented Jun 3, 2022

Codecov Report

Merging #43 (82009be) into main (4d9cfc5) will increase coverage by 0.37%.
The diff coverage is 93.74%.

@@            Coverage Diff             @@
##             main      #43      +/-   ##
==========================================
+ Coverage   91.10%   91.48%   +0.37%     
==========================================
  Files          21       21              
  Lines        2114     2208      +94     
==========================================
+ Hits         1926     2020      +94     
  Misses        188      188              
Impacted Files Coverage Δ
stormevents/usgs/sensors.py 56.00% <8.33%> (ø)
stormevents/nhc/storms.py 79.54% <78.94%> (ø)
stormevents/usgs/events.py 82.03% <81.25%> (+1.64%) ⬆️
stormevents/nhc/track.py 92.30% <94.48%> (+0.18%) ⬆️
stormevents/usgs/highwatermarks.py 93.65% <94.73%> (+0.15%) ⬆️
stormevents/nhc/atcf.py 92.16% <96.77%> (+0.19%) ⬆️
stormevents/coops/tidalstations.py 91.50% <96.87%> (+0.11%) ⬆️
stormevents/coops/__init__.py 100.00% <100.00%> (ø)
stormevents/stormevent.py 95.88% <100.00%> (+0.34%) ⬆️
stormevents/usgs/__init__.py 100.00% <100.00%> (ø)
... and 8 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 4d9cfc5...82009be. Read the comment docs.

@zacharyburnett zacharyburnett linked an issue Jun 3, 2022 that may be closed by this pull request
@zacharyburnett zacharyburnett merged commit 6b3fedf into main Jun 3, 2022
@zacharyburnett zacharyburnett deleted the fix/hwm_multistorm branch June 3, 2022 21:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Test fetching data for Hurricane Laura
1 participant