Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix the issue with data files not being copied to the installation directory #34

Merged
3 commits merged into from
Apr 12, 2022
Merged

Fix the issue with data files not being copied to the installation directory #34

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
e022294
Copy required json file to install dir
SorooshMani-NOAA Apr 7, 2022
7abad51
Raise error when http request fails
SorooshMani-NOAA Apr 7, 2022
760d98a
Merge branch 'main' into fix/pkg_data
zacharyburnett Apr 11, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 3 additions & 0 deletions setup.cfg
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -37,3 +37,6 @@ documentation =
m2r2
sphinx
sphinx-rtd-theme

[options.package_data]
* = *.json
2 changes: 2 additions & 0 deletions stormevents/nhc/storms.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -221,6 +221,8 @@ def nhc_storms_gis_archive(year: int = None) -> pandas.DataFrame:

url = 'http://www.nhc.noaa.gov/gis/archive_wsurge.php'
response = requests.get(url, params={'year': year})
if not response.ok:
response.raise_for_status()
soup = BeautifulSoup(response.content, features='html.parser')
table = soup.find('table')

Expand Down