Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fill missing values in MRD and MSLP #31

Merged
12 commits merged into from
Apr 11, 2022
Merged

fill missing values in MRD and MSLP #31

12 commits merged into from
Apr 11, 2022

Conversation

ghost
Copy link

@ghost ghost commented Mar 30, 2022

closes #26

@ghost ghost added the enhancement New feature or request label Mar 30, 2022
@ghost ghost marked this pull request as draft March 30, 2022 13:37
@ghost ghost force-pushed the feature/fill_mrd_mslp branch from ba2992a to 02ea621 Compare March 30, 2022 13:45
@codecov
Copy link

codecov bot commented Mar 30, 2022

Codecov Report

Merging #31 (c4b55aa) into main (1a32b4a) will decrease coverage by 0.04%.
The diff coverage is 97.05%.

❗ Current head c4b55aa differs from pull request most recent head beae18f. Consider uploading reports for the commit beae18f to get more accurate results

@@            Coverage Diff             @@
##             main      #31      +/-   ##
==========================================
- Coverage   90.66%   90.62%   -0.05%     
==========================================
  Files          22       22              
  Lines        2079     2079              
==========================================
- Hits         1885     1884       -1     
- Misses        194      195       +1     
Impacted Files Coverage Δ
stormevents/nhc/track.py 91.00% <96.61%> (-0.31%) ⬇️
stormevents/nhc/atcf.py 87.79% <100.00%> (+0.36%) ⬆️
tests/test_nhc.py 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 1a32b4a...beae18f. Read the comment docs.

@WPringle
Copy link
Contributor

@zacharyburnettNOAA Please also see comment I made on #30.
There are many zero forecast hour OFCL and CARQ's in the advisory file, we first need to parse out which one we need (same initial forecast datetime).

@ghost ghost force-pushed the feature/fill_mrd_mslp branch from ba6b1ff to de470fc Compare March 30, 2022 16:16
@ghost ghost marked this pull request as ready for review April 4, 2022 14:49
@ghost ghost self-assigned this Apr 4, 2022
@ghost ghost merged commit c21c80f into main Apr 11, 2022
@ghost ghost deleted the feature/fill_mrd_mslp branch April 11, 2022 15:48
This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
Development

Successfully merging this pull request may close these issues.

NHC forecast parsing
2 participants