-
Notifications
You must be signed in to change notification settings - Fork 8
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add option for choosing rmw fill method #112
Conversation
@WPringle I'm not sure if it'd be helpful or not to accept Also I was wondering what you think about the names I defaulted it to be the new psurge method. Please let me know what you think ... I'll add some tests soon |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #112 +/- ##
==========================================
+ Coverage 91.38% 91.71% +0.32%
==========================================
Files 19 19
Lines 2009 2087 +78
==========================================
+ Hits 1836 1914 +78
Misses 173 173 ☔ View full report in Codecov by Sentry. 🚨 Try these New Features:
|
@SorooshMani-NOAA Thank you! The |
@WPringle I also would like it to be short, so maybe |
Other name suggestions discussed:
I agree that having By the way @WPringle having only |
Defaults to PSurge v2.9 method.