Upload and retain opam.exe artifact #5762
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Makes it easy for code reviewers (so they don't have to rebuild the source code). Makes it easy to compare-and-constrast old version. Helps ocaml#5718
1 task
|
Thanks a lot for the idea! |
… PR 'CI:BINARIES', available for 15 days
|
Updated the PR with:
|
|
oups, there is no gh cli on windows jobs. |
|
Windows artifacts are already uploaded since 9ccb2d1 but i'm not sure macOS needs it too given how fast opam takes to compile on there. I'd be incline to close this if everyone agrees. |
|
The artifacts were generated because of how difficult it was to reproduce the exact environment (C compiler, Unix shell, 3rd party downloads) that generated the opam.exe binary of a PR. Much more difficult on Windows than other OS-es. The compile speed was unimportant. If no one has complained on other OS-es, then okay to drop. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Makes it easy for code reviewers (so they don't have to rebuild the source code). Makes it easy to compare-and-constrast old version.
Helps #5718