Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

system: fix apply_cygpath_path_transform #5716

Merged
merged 1 commit into from
Nov 13, 2023
Merged

system: fix apply_cygpath_path_transform #5716

merged 1 commit into from
Nov 13, 2023

Conversation

rjbou
Copy link
Collaborator

@rjbou rjbou commented Nov 2, 2023

No description provided.

@rjbou rjbou added the KIND: BUG label Nov 2, 2023
@rjbou rjbou added this to the 2.2.0~alpha3 milestone Nov 2, 2023
@rjbou rjbou requested a review from dra27 November 2, 2023 18:05
@rjbou
Copy link
Collaborator Author

rjbou commented Nov 13, 2023

rebased!

dra27
dra27 approved these changes Nov 13, 2023
View reviewed changes
Copy link
Member

@dra27 dra27 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks! Verified locally that it fixes the underlying problem

@kit-ty-kate
Copy link
Member

Thanks!

@kit-ty-kate kit-ty-kate merged commit 73583fc into ocaml:master Nov 13, 2023
29 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kit-ty-kate kit-ty-kate kit-ty-kate approved these changes

@dra27 dra27 dra27 approved these changes

Assignees
No one assigned
Labels
AREA: PORTABILITY KIND: BUG
Projects
None yet
Milestone
2.2.0~alpha3
Development

Successfully merging this pull request may close these issues.
3 participants
@rjbou @kit-ty-kate @dra27