reftest: add test for variables resolutions in filter, for all fields #5643

rjbou · 2023-08-24T15:58:50Z

No description provided.

dra27

I haven't gone through the test properly, but unlike #5642, I think this one is a good candidate for a reftest. I half wondered with the tests which produce messages if it would be worth piping the whole thing through an appropriate grep just to keep the output smaller?

dra27 · 2024-05-09T13:35:53Z

src/core/opamSystem.ml

+      match OpamProcess.run
+              (make_command ~verbose:OpamCoreConfig.(!r.verbose_level >= 3)
+                 ~name:"patch" patch_cmd ["--version"]) with


It doesn't feel like a good to stop having -vv display all commands run... is there anywhere else we already do this?

I don't think this change should be part of this PR

I've removed that part from the PR. Feel free to revert to the previous commit if you prefer to have the previous version

After checking, not really, the other instances are for verbose level >= 2. The only instance where it is >=3 is for commands run by depext, to avoid the big log.

tests/reftests/filter-variable-resolution.test

tests/reftests/run.ml

kit-ty-kate · 2024-09-02T13:15:34Z

tests/reftests/filter-variable-resolution.test

+### <pkg:patches.1:some-content>
+blabla
+pioupiou
+bloblob
+### <pkg:patches.1:to-apply.patch>
+--- a/some-content	2020-12-02 14:22:55.364620832 +0100
++ b/some-content	2020-12-02 14:23:05.668686881 +0100
+@@ -1,3 +1,3 @@
+ blabla
+-pioupiou
+ploplop
+ bloblob
+### <pkg:patches.1:to-not-apply.patch>
+--- a/some-content	2020-12-02 14:22:55.364620832 +0100
++ b/some-content	2020-12-02 14:23:05.668686881 +0100
+@@ -2,3 +2,3 @@
+ ploplop
+-bloblob
+noooooo
+### <pkg:patches.1>
+opam-version: "2.0"
+patches: [
+  "to-apply.patch" { ?smtg }
+  "to-not-apply.patch" { !?smtg }
+]
+build: [
+  [ "grep" "ploplop" "some-content" ]
+  [ "grep" "bloblob" "some-content" ]
+]


This section is already defined in line 18 of the same file

kit-ty-kate · 2024-09-02T13:15:48Z

tests/reftests/filter-variable-resolution.test

+### <pkg:build.1>
+opam-version: "2.0"
+build: [
+  [ "true" { ?smtg } ]
+  [ "false" { !?smtg } ]
+]


already defined above

kit-ty-kate · 2024-09-02T13:15:55Z

tests/reftests/filter-variable-resolution.test

+### <pkg:install.1>
+opam-version: "2.0"
+install: [
+  [ "true" { ?smtg } ]
+  [ "false" { !?smtg } ]
+]


kit-ty-kate · 2024-09-02T13:17:14Z

tests/reftests/filter-variable-resolution.test

+### <pkg:runtest.1>
+opam-version: "2.0"
+run-test: [
+  [ "true" { ?smtg } ]
+  [ "false" { !?smtg } ]
+]


kit-ty-kate · 2024-09-02T13:18:43Z

tests/reftests/filter-variable-resolution.test

+### <pkg:post-msg.1>
+opam-version: "2.0"
+post-messages: [
+  "Bye!" { ?smtg }
+  ">>smtg is undefined<<" { !?smtg }
+]


kit-ty-kate · 2024-09-02T13:18:49Z

tests/reftests/filter-variable-resolution.test

+### <pkg:avail.1>
+opam-version: "2.0"
+available: [ ?smtg ]


kit-ty-kate · 2024-09-02T13:19:20Z

tests/reftests/filter-variable-resolution.test

+### <pkg:patches.1:some-content>
+blabla
+pioupiou
+bloblob
+### <pkg:patches.1:to-apply.patch>
+--- a/some-content	2020-12-02 14:22:55.364620832 +0100
++ b/some-content	2020-12-02 14:23:05.668686881 +0100
+@@ -1,3 +1,3 @@
+ blabla
+-pioupiou
+ploplop
+ bloblob
+### <pkg:patches.1:to-not-apply.patch>
+--- a/some-content	2020-12-02 14:22:55.364620832 +0100
++ b/some-content	2020-12-02 14:23:05.668686881 +0100
+@@ -2,3 +2,3 @@
+ ploplop
+-bloblob
+noooooo


these files don't have to be redefined

kit-ty-kate · 2024-09-02T13:21:43Z

tests/reftests/filter-variable-resolution.test

+### <pkg:patches.1:some-content>
+blabla
+pioupiou
+bloblob
+### <pkg:patches.1:to-apply.patch>
+--- a/some-content	2020-12-02 14:22:55.364620832 +0100
++ b/some-content	2020-12-02 14:23:05.668686881 +0100
+@@ -1,3 +1,3 @@
+ blabla
+-pioupiou
+ploplop
+ bloblob
+### <pkg:patches.1:to-not-apply.patch>
+--- a/some-content	2020-12-02 14:22:55.364620832 +0100
++ b/some-content	2020-12-02 14:23:05.668686881 +0100
+@@ -2,3 +2,3 @@
+ ploplop
+-bloblob
+noooooo


these files don't have to be redefined

kit-ty-kate · 2024-09-02T13:26:22Z

tests/reftests/filter-variable-resolution.test

+### :::::::::::::::::::::::::::
+### :: Self package variable ::
+### :::::::::::::::::::::::::::


for this section i think it would be also be useful to show the behaviour of opam when the package has already been installed. Like, for each fields, show the behaviour as is done currently, then force-install the package and try to install it again and show if there is a difference of behaviour

updated with these tests in a separate commit

rjbou

On file definition redundancy, the main idea is to have all information about the given test in its section. But there is 2 different cases:

patches that never changes, are always redefined, and their content it not so much important to understand the given test
opam files that are the same for a subset of the tests, they are more important to understand why it fails or not (how is used the variable).
I think that patches can be grouped at the beginning of the test, but opam files add more readability if they are duplicated in their own section.

rjbou · 2024-10-14T17:38:11Z

tests/reftests/filter-variable-resolution.test

+### :::::::::::::::::::::::::::
+### :: Self package variable ::
+### :::::::::::::::::::::::::::


updated with these tests in a separate commit

rjbou added the AREA:TEST label Aug 24, 2023

rjbou force-pushed the test-resolve-variables-in-filters branch from 2e16743 to 0f61464 Compare August 24, 2023 15:59

rjbou force-pushed the test-resolve-variables-in-filters branch from c191f42 to d53f6f9 Compare September 20, 2023 13:55

rjbou force-pushed the test-resolve-variables-in-filters branch from d53f6f9 to 25837cf Compare December 12, 2023 10:13

rjbou added the PR: WAITING FOR REVIEW label Dec 12, 2023

rjbou force-pushed the test-resolve-variables-in-filters branch from 25837cf to 930e28e Compare April 9, 2024 16:52

rjbou requested review from kit-ty-kate and dra27 May 3, 2024 08:49

kit-ty-kate removed their request for review May 9, 2024 13:24

dra27 reviewed May 9, 2024

View reviewed changes

rjbou added this to the 2.3 milestone Jun 27, 2024

kit-ty-kate force-pushed the test-resolve-variables-in-filters branch from 97f6c16 to d2b04b6 Compare July 9, 2024 18:08

kit-ty-kate approved these changes Jul 9, 2024

View reviewed changes

kit-ty-kate added STATE: READY TO MERGE and removed PR: WAITING FOR REVIEW labels Jul 9, 2024

rjbou commented Jul 10, 2024

View reviewed changes

tests/reftests/filter-variable-resolution.test Outdated Show resolved Hide resolved

rjbou marked this pull request as draft July 10, 2024 13:55

kit-ty-kate removed the STATE: READY TO MERGE label Jul 15, 2024

rjbou force-pushed the test-resolve-variables-in-filters branch from d2b04b6 to a9c2b0a Compare August 29, 2024 18:11

rjbou marked this pull request as ready for review August 29, 2024 18:11

rjbou added the PR: WAITING FOR REVIEW label Aug 29, 2024

rjbou requested a review from kit-ty-kate August 29, 2024 18:11

kit-ty-kate reviewed Sep 2, 2024

View reviewed changes

rjbou added PR: NEEDS UPDATE and removed PR: WAITING FOR REVIEW labels Sep 16, 2024

kit-ty-kate modified the milestones: 2.3.0~alpha1, 2.4.0~alpha1 Sep 18, 2024

rjbou added 2 commits October 14, 2024 17:51

reftest: add test for variables resolutions in filter, for all fields

7758fb0

!fixup add self package variable reinstall tests

4972b20

rjbou force-pushed the test-resolve-variables-in-filters branch from a9c2b0a to 4972b20 Compare October 14, 2024 17:38

rjbou commented Oct 14, 2024

View reviewed changes

rjbou added PR: WAITING FOR REVIEW and removed PR: NEEDS UPDATE labels Oct 16, 2024

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

reftest: add test for variables resolutions in filter, for all fields #5643

reftest: add test for variables resolutions in filter, for all fields #5643

rjbou commented Aug 24, 2023

dra27 left a comment

dra27 May 9, 2024

kit-ty-kate Jul 9, 2024

kit-ty-kate Jul 9, 2024

rjbou Jul 10, 2024

kit-ty-kate Sep 2, 2024

kit-ty-kate Sep 2, 2024

kit-ty-kate Sep 2, 2024

kit-ty-kate Sep 2, 2024

kit-ty-kate Sep 2, 2024

kit-ty-kate Sep 2, 2024

kit-ty-kate Sep 2, 2024

kit-ty-kate Sep 2, 2024

kit-ty-kate Sep 2, 2024

rjbou Oct 14, 2024

rjbou left a comment

rjbou Oct 14, 2024

reftest: add test for variables resolutions in filter, for all fields #5643

Are you sure you want to change the base?

reftest: add test for variables resolutions in filter, for all fields #5643

Conversation

rjbou commented Aug 24, 2023

dra27 left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

rjbou left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment