-
Notifications
You must be signed in to change notification settings - Fork 358
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update release scripts #5616
Update release scripts #5616
Conversation
rjbou
commented
Jul 25, 2023
- Update sign script to sign only binaries, and sign archive
- Makefile: use vendoredps deps instead of make lib-ext
- Bump OpenBSD to 7.3
- Update release script to run it on mac or linux
- I updated it according my setup
- It is not yet tested with current script.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
What is the purpose of running it on Linux if we need to run it on mac anyway to build the mac binaries?
@@ -108,8 +108,7 @@ host: $(OUTDIR)/opam-full-$(VERSION).tar.gz build/$(HOST).env | |||
MAKE=$(MAKE) \ | |||
$(EXPORTS_$(HOST_OS)); \ | |||
cd build/opam-full-$(VERSION) && \ | |||
./configure && \ | |||
{ $(MAKE) lib-ext || ./configure --with-vendored-deps; } && \ | |||
./configure --with-vendored-deps && \ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is still required to make releases of the 2.1 branch
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There is also another thing that is 2.1 related, sha dependency. Should we have conditional commands according 2.1/2.2 ?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
What is sha dependency?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This one
I don't have access to a graphical mac session :) I build everything on my deb, and the mac binaries via ssh on a mac. |
is the GUI really required? |
it's on he device requirement
|
I wrote it that way only because I'm doing that personally and I've never had to do in on a mac without GUI but it should be possible |