Some windows shell updates #5541
Merged
+530
−348
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rjbou
force-pushed
the
more-windows-shell
branch
3 times, most recently
from
9444b32
to
10b6d88
Compare
AltGr
approved these changes
Jun 12, 2023
It has a Wikipedia page and everything!
The old DOS style - curiously - is used in the command descriptions and then all the examples use lowercase (as do most shell scripts written these days).
The PowerShell implementation isn't yet correct and the Command Processor will never have one. Refactor the code to skip .profile files for those.
Read the entire process ancestry in a single snapshot and then return the full image names to opam. This makes the shell analysis slightly more efficient. The full image paths rather than just the executable names pave the way for opam to be able to initialise PowerShell properly.
rjbou
force-pushed
the
more-windows-shell
branch
from
10b6d88
to
4a31da2
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is a subset of #5220