src_ext: Remove unused/untested Makefile targets #5494
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Slightly in passing - I'm completely for removing this, but preferably after 2.2 (i.e. after there's a released Windows opam which does away with the use case for it). It is useful (and used, certainly by me!) for developing opam on Windows, because the build is a lot faster than the vendored route when working on opam itself. It's also in use in the base image builder at the moment. It is also tested - see dra27@ee6e3a5 which demonstrates the breakage this commit presently causes in the Cold job (the Cold job in the PR is passing because #4776 means that the build is quietly downloading the dependencies which haven't been installed). |
kit-ty-kate
force-pushed
the
rm-unused-vendoring-primitives
branch
2 times, most recently
from
08cfd31
to
a527326
Compare
kit-ty-kate
force-pushed
the
rm-unused-vendoring-primitives
branch
from
a527326
to
2a57626
Compare
kit-ty-kate
force-pushed
the
rm-unused-vendoring-primitives
branch
from
2a57626
to
d5142f8
Compare
dra27
approved these changes
Jun 4, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I don't think anyone use that, and we're not testing it either.
Also it complicates vendoring of dependencies so I feel like any simplification in there is always welcome.