-
Notifications
You must be signed in to change notification settings - Fork 358
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Reftests: factorise some repo hashes #5380
base: master
Are you sure you want to change the base?
Conversation
Have you checked that those two tests still have the same behaviours if this patch was applied before their respective fixes? |
|
#5414 used in another test a removed hash in this PR. Need to be reviewed |
I’m not sure it’s worth potentially breaking carefully crafted tests just to save 3 secondes (i tried) in total test time |
What is broken ? |
I don’t know, I saying potentially. When writing tests there are many factors that appears when choosing a repository hash, many of which might not appear in the results before or after the commit that added the test and its fix. To me it’s not worth the hassle. |
In the current state of the PR, I checked that it is the same before and after fix, when there is an after |
as i said, many invariants do not appear in the results before or after |
oups, i misread. Then what are the other things that you check when choosing an hash, except that it permits you to have the "good" test output ? |
No description provided.