-
Notifications
You must be signed in to change notification settings - Fork 358
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Support --json option in opam tree #5303
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the PR!
I've moved the test to json testfile, and added some commands to test (with error, with simulated)
thoughts from dev meeting: we should add switch name into the json, no need to add error / simulated state |
This comment was marked as outdated.
This comment was marked as outdated.
Oops I broke some other tests in |
@rjbou All the other subcommands are using the default man for |
@smorimoto Could you confirm on whether or not this is what you wanted? |
@kit-ty-kate Yes! That looks OK! Let's go! |
When will this be deployed? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
Wondering on some wordings:
is_dup
->is_duplicate
?demands
orsatisfies
are they enough indicative ?
I didn't come up with better terms than demands/satisfies... |
|
Updates? |
queued on #5405 |
Thanks! |
Thank you for everyone! |
Closes #5298.
This PR adds support for
--json
option inopam tree
command.Here is an example output: https://gist.github.com/cannorin/ae87f55695c38356a9b880e0418a7a12
Currently, the output JSON has the type
Forest
in the following TS definition:We discuss the structure of the output JSON in #5298.
TODO:
Update doc and mannot neededmaster_changes.md