Ensure package variables are available at package install #4841
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rjbou
added
the
PR: QUEUED
When a package is installed, the switch environment is recomputed and written, but if the setenv fields referred to package variables just written to .config then these weren't available as the switch state didn't include the new config file. Subsequent calls to opam would then fix the issue as the .config file will have been loaded with the switch state.
rjbou
removed
the
PR: QUEUED
This was referenced Oct 19, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
ocamlpackage uses the stublibs variable defined during its build insetenv:This has never worked when the package was installed, because although
ocaml.configis correctly installed, it wasn't added to the switch state. Thus on switch creation,CAML_LD_LIBRARY_PATHis incorrect. At the next call toopam install(or anything else which refreshed theenvironmentfile) this would be corrected, but I have a feeling we have seen errors relating to this before.This PR threads the config back through the install process to
OpamSolutionso that it can update the state.