Harsher CI #4672
Merged
Harsher CI #4672
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is done by adding a line to Makefile.config after configure, rather than setting DUNE_PROFILE in the environment since other dune invocations may read DUNE_PROFILE (e.g. in opam-rt dependencies).
dra27
commented
May 19, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The builds of opam in CI should be done in dev mode.
My initial implementation simply used
DUNE_PROFILEin the environment, but that's spawned ocaml/dune#4632, so I've instead added it toMakefile.configafterconfigureis run. The two places whereDUNE_PROFILEis used in the build system both set it with?=(to allow an environment override) and also both readMakefile.config, so this will work. I also dealt with a TODO comment from #4545, in order to prevent any future accidental breakage of this.