Update opam repository man doc #4435
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dra27
reviewed
Dec 17, 2020
There was a problem hiding this comment.
I've re-worded the message text, but I don't think is sufficient - the 2.0 behaviour here is really surprising. On my opam root, which has two default repositories, this means that if you remove the last repo from a switch's selection then you suddenly have two repos added!
I think this also be displayed as a warning when it happens - i.e. if OpamSwitchState.update_repositories has restored the list to the default then the "Repositories removed from the selections of switch %s." message should also be "There are no repositories selected, so the selections have been restored to the default selection."
XVilka
approved these changes
Jan 8, 2021
|
Hah, not to worry @XVilka - it appears I can delete your comment, but not the review! |
Co-authored-by: David Allsopp <[email protected]>
kit-ty-kate
approved these changes
Jan 20, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fix #4381