Fix cppo detection in configure #3915
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
lgtm! |
dra27
pushed a commit
to dra27/opam
that referenced
this pull request
Jul 4, 2019
Fix cppo detection in configure (cherry picked from commit 87059cc)
AltGr
added a commit
that referenced
this pull request
Jul 5, 2019
Merge pull request #3915 from dra27/fix-cppo
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a cosmetic change, since
cppois a dependency of several of opam's dependencies, butopamchecks for thecppoocamlfind package, rather than thecppotool itself. This works fine on an opam installation, owing to ocaml/dune#2353, but fails on Debian, where thecppopackage (correctly) does not install aMETAfile.With this change,
./configurenow doesn't display the "run make lib-ext" message because of a missingcppopackage. I have changed the detection to look at$CPPO, but this is academic since several of the libraries depend on cppo.This is for master and 2.0