Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

opam doesn't detect homebrew installed python3 #5023

Closed
k4rtik opened this issue Jan 24, 2022 · 8 comments
Closed

opam doesn't detect homebrew installed python3 #5023

k4rtik opened this issue Jan 24, 2022 · 8 comments

Comments

@k4rtik
Copy link

k4rtik commented Jan 24, 2022

❯ opam config report
# opam config report
# opam-version         2.1.2
# self-upgrade         no
# system               arch=arm64 os=macos os-distribution=homebrew os-version=12.1
# solver               builtin-mccs+glpk
# install-criteria     -removed,-count[avoid-version,changed],-count[version-lag,request],-count[version-lag,changed],-count[missing-depexts,changed],-changed
# upgrade-criteria     -removed,-count[avoid-version,changed],-count[version-lag,solution],-count[missing-depexts,changed],-new
# jobs                 9
# repositories         4 (http), 6 (local), 1 (version-controlled) (default repo at 3920a74b)
# pinned               0
# current-switch       latest
# ocaml:native         true
# ocaml:native-tools   true
# ocaml:native-dynlink true
# ocaml:stubsdir       /Users/kartik/.opam/latest/lib/ocaml/stublibs:/Users/kartik/.opam/latest/lib/ocaml
# ocaml:preinstalled   false
# ocaml:compiler       4.13.1

❯ brew list | grep python
[email protected]
[email protected]

❯ opam install conf-python-3
The following actions will be performed:
  ∗ install conf-python-3 1.0.0

The following system packages will first need to be installed:
    python@3

<><> Handling external dependencies <><><><><><><><><><><><><><><><><><><><>  🐫
Let opam run your package manager to install the required system packages?
(answer 'n' for other options) [Y/n] y
+ /opt/homebrew/bin/brew "install" "python@3"
- Warning: [email protected] 3.9.10 is already installed and up-to-date.
- To reinstall 3.9.10, run:
-   brew reinstall [email protected]

<><> Processing actions <><><><><><><><><><><><><><><><><><><><><><><><><><>  🐫
∗ installed conf-python-3.1.0.0
Done.

❯ opam config report
# opam config report
# opam-version         2.1.2
# self-upgrade         no
# system               arch=arm64 os=macos os-distribution=homebrew os-version=12.1
# solver               builtin-mccs+glpk
# install-criteria     -removed,-count[avoid-version,changed],-count[version-lag,request],-count[version-lag,changed],-count[missing-depexts,changed],-changed
# upgrade-criteria     -removed,-count[avoid-version,changed],-count[version-lag,solution],-count[missing-depexts,changed],-new
# jobs                 9
# repositories         4 (http), 6 (local), 1 (version-controlled) (default repo at 3920a74b)
# pinned               0
# current-switch       latest
[WARNING] Opam package conf-python-3.1.0.0 depends on the following system package that can no longer be found: python@3
# ocaml:native         true
# ocaml:native-tools   true
# ocaml:native-dynlink true
# ocaml:stubsdir       /Users/kartik/.opam/latest/lib/ocaml/stublibs:/Users/kartik/.opam/latest/lib/ocaml
# ocaml:preinstalled   false
# ocaml:compiler       4.13.1

Notice the warning in the second output of opam config report:

[WARNING] Opam package conf-python-3.1.0.0 depends on the following system package that can no longer be found: python@3

@rjbou
Copy link
Collaborator

rjbou commented Jan 24, 2022

The issue here is: when it is asked to brew to install python@3, it installs [email protected] and it is listed only as [email protected]. So opam, when pooling system install status, doesn't see python@3. Kind of virtual/aliases package no handling.
For the moment, we list installed packages with brew list --full-name. Do you know what would be the command to list also those alias packages?

@kit-ty-kate
Copy link
Member

We could go through the output of brew info --json=v1 --installed

@k4rtik
Copy link
Author

k4rtik commented Jan 24, 2022

Is it not possible to use the return code of the brew list --full-name python3 command?

PlatiniumM1Pro in ~
❯ brew list --full-name python3
[email protected]

PlatiniumM1Pro in ~ took 570ms
❯ brew list --full-name python2
Error: No available formula with the name "python2". Did you mean ipython, bpython, jython or cython?

PlatiniumM1Pro in ~ took 651ms
✗ brew list --full-name python@3
[email protected]

PlatiniumM1Pro in ~ took 596ms
❯

Notice, for python 2 the return code is not 0 (success) marked by ✗ in my shell output.

@kit-ty-kate
Copy link
Member

Sadly brew list --full-name <pkg> would have to be called for each homebrew depexts in opam, that would take too long (0.5s per depexts)

@kit-ty-kate
Copy link
Member

xref #4759

@k4rtik
Copy link
Author

k4rtik commented Jan 24, 2022

That makes sense.

Another thought is how many virtual packages are there? If not too many, perhaps the OCaml code for pooling can make exceptions for those by either grepping the version from the package name after the @ symbol in the package name or call brew list --full-name <pkg> explicitly for just those packages.

@rjbou
Copy link
Collaborator

rjbou commented Jan 25, 2022

It's not conceivable, it will take time (depext mechanism must remain very short, it is called for half opam commands), and if we hard code virtual packages list, users need to wait for an release of opam for each new package added.

We'll try to dig with brew info, it seems the best solution.

In the meantime, you can fix your setup by telling to opam that python@3 system package is well installed, using assume-depext feature: opam option depext-bypass='["python@3"]' --global

@kit-ty-kate kit-ty-kate added this to the 2.2.0~alpha milestone Feb 4, 2022
@dra27 dra27 removed this from the 2.2.0~alpha milestone May 17, 2022
@dra27
Copy link
Member

dra27 commented May 17, 2022

We're considering a different way of tackling external dependencies in opam 3.x which might be able to fix this properly, but in the meantime it's at least possible to add the explicit bypass as noted in #5023 (comment). This isn't fixable in an adequate way with the 2.x depext system - closing this as wontfix, for now.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants