Apply suggestions from code review

Co-authored-by: Kate <[email protected]>
ocaml · Oct 21, 2024 · d304842 · d304842
1 parent b43c23e
commit d304842
Show file tree

Hide file tree

Showing 2 changed files with 5 additions and 6 deletions.
diff --git a/src/client/opamAdminCommand.ml b/src/client/opamAdminCommand.ml
@@ -336,8 +336,8 @@ let check_opam_file_version_url has_error repo_root prefix nv opam =
   let min_opam_version = OpamVersion.of_string "2.0" in
   let url_file =
     let ( // ) = OpamFilename.Op.( // ) in
-    OpamFile.(make
-                (OpamRepositoryPath.packages repo_root prefix nv // "url"))
+    OpamFile.make
+      (OpamRepositoryPath.packages repo_root prefix nv // "url")
   in
   if OpamFile.exists url_file then
     (OpamConsole.warning "Not updating external URL file at %s"

diff --git a/src/client/opamAdminRepoUpgrade.ml b/src/client/opamAdminRepoUpgrade.ml
@@ -430,10 +430,9 @@ let do_upgrade repo_root =
           (OpamFile.OPAM.write_with_preserved_format opam_file opam;
            let ( // ) = OpamFilename.Op.( // ) in
            List.iter OpamFilename.remove [
-             OpamFile.(filename (make
-                                   (OpamRepositoryPath.packages repo_root prefix package // "descr")));
-             OpamFile.(filename (make
-                                   (OpamRepositoryPath.packages repo_root prefix package // "url")));
+             let path = OpamRepositoryPath.packages repo_root prefix package in
+             OpamFile.filename (OpamFile.make (path // "descr"));
+             OpamFile.filename (OpamFile.make (path // "url"));
            ];
            OpamConsole.status_line "Updated %s" (OpamFile.to_string opam_file))
     )