-
Notifications
You must be signed in to change notification settings - Fork 1.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Package ppx_mica.0.1.0 #26652
Package ppx_mica.0.1.0 #26652
Conversation
Hello! Thank you for publishing your package! Mica looks super cool and I am looking forward to trying it out. (The readme is extremely clear!) Since it looks like this is your first time publishing a package to opam, allow me offer a warm welcome and a bit of an intro :) We run a CI system to ensure that packages can be installed on all intended systems. You can see the results for your PR at https://opam.ci.ocaml.org/github/ocaml/opam-repository/commit/51b56fad1033fa4ad04b706eef5074af6f223397 (or by clicking the This shows the results of the builds and tests across our build matrix. Because we build and test on such a large matrix, it is very common for errors to be identified during package publication. In my following comments and suggestions, I'll try to provide pointers and suggestions to get everything squared away. Please let us know if you have any questions, as we are here to help :) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think this should address all the errors I am seeing!
51b56fa
to
9c63f9a
Compare
Thanks @shonfeder for the comments! I found them very helpful as a first-time package author. I've edited the PR so that there's only one package ( |
9c63f9a
to
07a5b35
Compare
Caught in the CI for ocaml/opam-repository#26652
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you for the fixes and the package clean up! Things are looking quite good :)
There is one more error turning up in the ci dune to a missing dependency.
I opened ngernest/mica#3 to fix this in the source, and the suggestions here should take care of this package (tho pushing an update from the opam file your dev repo is a fine alternative to adding the changes here directly).
Looking forward to having this in the repo! Today I was day dreaming about whether we could use your work here in our CI system somehow to detect breaking changes between releases :D
07a5b35
to
5c5c59a
Compare
Thanks for the fixes & for the PR (I merged your PR)! I pushed an update from the Opam file in my dev repo (I added a documentation stanza in my |
It's working! Everything is coming up green. Thanks very much for your patience in the process and for publishing the package! Done forget to announce in discuss.ocaml.org :) |
@shonfeder Thank you so much for all your help! I learned a lot and really enjoyed the process! |
ppx_mica.0.1.0
PPX deriver that automates differential testing for OCaml modules
🐫 Pull-request generated by opam-publish v2.4.0