Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Package ppx_mica.0.1.0 #26652

Merged
merged 1 commit into from
Oct 4, 2024
Merged

Conversation

ngernest
Copy link
Contributor

@ngernest ngernest commented Oct 1, 2024

ppx_mica.0.1.0

PPX deriver that automates differential testing for OCaml modules



🐫 Pull-request generated by opam-publish v2.4.0

@shonfeder
Copy link
Contributor

shonfeder commented Oct 2, 2024

Hello! Thank you for publishing your package! Mica looks super cool and I am looking forward to trying it out. (The readme is extremely clear!)

Since it looks like this is your first time publishing a package to opam, allow me offer a warm welcome and a bit of an intro :)

We run a CI system to ensure that packages can be installed on all intended systems. You can see the results for your PR at https://opam.ci.ocaml.org/github/ocaml/opam-repository/commit/51b56fad1033fa4ad04b706eef5074af6f223397 (or by clicking the Details link next to the opam-ci status check).

This shows the results of the builds and tests across our build matrix. Because we build and test on such a large matrix, it is very common for errors to be identified during package publication.

In my following comments and suggestions, I'll try to provide pointers and suggestions to get everything squared away. Please let us know if you have any questions, as we are here to help :)

Copy link
Contributor

@shonfeder shonfeder left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this should address all the errors I am seeing!

packages/tyche_utils/tyche_utils.0.1.0/opam Outdated Show resolved Hide resolved
packages/tyche_utils/tyche_utils.0.1.0/opam Outdated Show resolved Hide resolved
packages/mica_case_studies/mica_case_studies.0.1.0/opam Outdated Show resolved Hide resolved
packages/ppx_mica/ppx_mica.0.1.0/opam Show resolved Hide resolved
@ngernest ngernest changed the title 3 packages from ngernest/mica at 0.1.0 Package ppx_mica.0.1.0 Oct 3, 2024
@ngernest
Copy link
Contributor Author

ngernest commented Oct 3, 2024

Thanks @shonfeder for the comments! I found them very helpful as a first-time package author.

I've edited the PR so that there's only one package (ppx_mica) and added lower bounds for its dependencies -- the other two packages (tyche_utils & mica_case_studies) aren't strictly necessary for end users, so I've removed them from this PR and isolated them in separate repos.

shonfeder added a commit to shonfeder/mica that referenced this pull request Oct 4, 2024
Copy link
Contributor

@shonfeder shonfeder left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for the fixes and the package clean up! Things are looking quite good :)

There is one more error turning up in the ci dune to a missing dependency.

I opened ngernest/mica#3 to fix this in the source, and the suggestions here should take care of this package (tho pushing an update from the opam file your dev repo is a fine alternative to adding the changes here directly).

Looking forward to having this in the repo! Today I was day dreaming about whether we could use your work here in our CI system somehow to detect breaking changes between releases :D

packages/ppx_mica/ppx_mica.0.1.0/opam Outdated Show resolved Hide resolved
packages/ppx_mica/ppx_mica.0.1.0/opam Show resolved Hide resolved
@ngernest
Copy link
Contributor Author

ngernest commented Oct 4, 2024

Thanks for the fixes & for the PR (I merged your PR)! I pushed an update from the Opam file in my dev repo (I added a documentation stanza in my dune-project file) and incorporated your changes, hopefully this works!

@shonfeder
Copy link
Contributor

It's working! Everything is coming up green. Thanks very much for your patience in the process and for publishing the package!

Done forget to announce in discuss.ocaml.org :)

@shonfeder shonfeder merged commit dd37f1d into ocaml:master Oct 4, 2024
3 checks passed
@ngernest
Copy link
Contributor Author

ngernest commented Oct 4, 2024

@shonfeder Thank you so much for all your help! I learned a lot and really enjoyed the process!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants