Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add ctypes 0.23.0 #26353

Merged
merged 1 commit into from
Aug 16, 2024
Merged

Add ctypes 0.23.0 #26353

merged 1 commit into from
Aug 16, 2024

Conversation

yallop
Copy link
Member

@yallop yallop commented Aug 12, 2024

No description provided.

@avsm
Copy link
Member

avsm commented Aug 13, 2024

Some test failures that may be worth looking into:

# File "tests/test-oo_style/stub-generator/dune", line 21, characters 9-24:
# 21 |   (names generated_stubs))
#               ^^^^^^^^^^^^^^^
# (cd _build/default/tests/test-oo_style/stub-generator && /usr/sbin/gcc -O2 -fno-strict-aliasing -fwrapv -pthread -fPIC -D_FILE_OFFSET_BITS=64 -g -I /home/opam/.opam/4.14/lib/ocaml -I /home/opam/.opam/4.14/lib/bigarray-compat -I /home/opam/.opam/4.14/lib/ctypes -I /home/opam/.opam/4.14/lib/integers -I /home/opam/.opam/4.14/lib/stdlib-shims -I ../../clib -o generated_stubs.o -c generated_stubs.c)
# generated_stubs.c: In function ‘cstubs_tests_2_new_chorse’:
# generated_stubs.c:14:25: error: initialization of ‘struct animal *’ from incompatible pointer type ‘struct chorse *’ [-Wincompatible-pointer-types]
#    14 |    struct animal* x10 = new_chorse(x7);
#       |                         ^~~~~~~~~~

@yallop
Copy link
Member Author

yallop commented Aug 13, 2024

The failure (also reported in yallop/ocaml-ctypes#784) appears to be a result of recent gcc releases turning what was previously a warning into an error. It's only a test failure, not a problem in library code. There's a fix in yallop/ocaml-ctypes#785 that'll be in the next ctypes release.

@avsm avsm merged commit 4385fef into ocaml:master Aug 16, 2024
2 of 3 checks passed
@avsm
Copy link
Member

avsm commented Aug 16, 2024

Thanks! You may want to announce this on https://discuss.ocaml.org, where we have a Community category and an announce tag for this purpose.

@yallop yallop deleted the ctypes-0.23.0 branch August 16, 2024 10:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants