-
Notifications
You must be signed in to change notification settings - Fork 1.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[package update] Autogenerated conf-libclang packages for LLVM upto 18.0 #25889
base: master
Are you sure you want to change the base?
[package update] Autogenerated conf-libclang packages for LLVM upto 18.0 #25889
Conversation
@kit-ty-kate sorry to bother, but you had a lot of experience with llvm/clang packages. Could you by chance have a look? |
looks fine to me |
All my apologies: there still are a lot of CI errors, I will ping you when I fixed most of them! |
4f286db
to
15567c8
Compare
7dba3fa
to
d660560
Compare
@@ -44,13 +44,13 @@ x-ci-accept-failures: [ | |||
"fedora-38" "fedora-39" "fedora-40" # clang-devel is not available | |||
"oraclelinux-9" # clang-devel is not available | |||
] | |||
extra-source "configure.sh": { | |||
extra-source "configure.sh" { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
extra-source "configure.sh" { | |
extra-source "configure.ml" { |
It's funny, it seems the |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just a few suggestions below related to fedora. Thank you for all the work @thierry-martinez!
["libclang-11-dev" "libclang-cpp11-dev" "llvm-11-dev"] { os-distribution = "debian" & os-version = "10" } | ||
["clang-devel-12.0.1" "llvm-devel-12.0.1" "llvm-static-12.0.1" "zlib-devel"] | ||
{os-distribution = "ol" & os-version >= 8 & os-version < 9} | ||
["clang12-devel" "llvm12-devel" "llvm12-static" "zlib-devel" "redhat-rpm-config"] |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
["clang12-devel" "llvm12-devel" "llvm12-static" "zlib-devel" "redhat-rpm-config"] | |
["clang11-devel" "llvm11-devel" "llvm11-static" "zlib-devel" "redhat-rpm-config"] |
Maybe that could be sufficient to fix fedora 39?
["libclang-13-dev" "libclang-cpp13-dev" "llvm-13-dev"] { os-distribution = "debian" & os-version = "10" } | ||
["clang-devel-14.0.6" "llvm-devel-14.0.6" "llvm-static-14.0.6" "zlib-devel"] | ||
{os-distribution = "ol" & os-version >= 8} | ||
["clang14-devel" "llvm14-devel" "llvm14-static" "zlib-devel" "redhat-rpm-config"] |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
For fedora 40, I would suggest
["clang13-devel" "llvm13-devel" "llvm14-static" "zlib-devel" "redhat-rpm-config"]
@thierry-martinez I was wondering if you want to merge this as-is or...? |
Hi, @thierry-martinez! Just checking in here on your availability for landing this update. Please let us me know if there's support you need from the maintainer side. |
This merge request makes
conf-libclang.N
packages autogenerated so that each package ensures that a Clang library version N or below is installed. EDIT: The configure scripts are now written in OCaml, for instance: https://github.com/ocaml/opam-repository/blob/4f286db2006c405a0f54f789422cb3fca35daa49/packages/conf-libclang/conf-libclang.18/files/configure.ml (the OCaml modules are identical from oneconf-libclang
version to another).The generator is here:
https://github.com/thierry-martinez/conf-libclang/blob/main/generate.shEDIT: https://github.com/thierry-martinez/conf-libclang/blob/main/generate.ml