Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[new release] dune (15 packages) (3.14.2) #25474

Merged
merged 1 commit into from
Mar 13, 2024

Conversation

Leonidas-from-XIV
Copy link
Contributor

Fast, portable, and opinionated build system

CHANGES:

Fixed

CHANGES:

### Fixed

- fix compilation on non-glibc systems due to `signal.h` not being pulled in
  spawn stubs. (ocaml/dune#10256, @emillon)
@kit-ty-kate
Copy link
Member

Note for opam-repository maintainers: this release fixes a critical issue for dune on Windows (support of unicode characters in PATH, e.g. usernames with accents) and i would suggest all the older versions of dune to be restricted to available: os != "win32" in a separate PR, independently of this one (this one should be merged first though).

@emillon
Copy link
Contributor

emillon commented Mar 12, 2024

I don't understand the reasoning. This is something important to fix, but this is not a regression or anything. This is something that has never worked. The old versions of dune are working well for a bunch of windows users. Why force them to upgrade? The solver will pick the new version anyway.

@kit-ty-kate
Copy link
Member

Well there was never any Windows users using opam-repository as opam-repository is not currently available on Windows. People currently use forks that are not currently updated.
So for the opam-repository support on Windows that is coming soon, the reasoning is that it would be nice for every user to have a dune version that works regardless of whether or not they have unicode characters in their environment.

@Leonidas-from-XIV
Copy link
Contributor Author

We evaluated the revdep failures and didn't see any regressions that were due to changes between 3.14.0 and 3.14.2 so this should be ok to merge.

@raphael-proust
Copy link
Collaborator

Thank you!

@raphael-proust raphael-proust merged commit 7af6baf into ocaml:master Mar 13, 2024
1 of 2 checks passed
@Leonidas-from-XIV Leonidas-from-XIV deleted the release-dune-3.14.2 branch March 13, 2024 16:33
@samoht samoht mentioned this pull request Apr 1, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants