Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update ppxlib.0.32.1~5.2preview #25453

Merged
merged 2 commits into from
Mar 12, 2024

Conversation

NathanReb
Copy link
Contributor

Preview release with OCaml 5.2 compatibility

Preview release with OCaml 5.2 compatibility

Signed-off-by: Nathan Rebours <[email protected]>
@NathanReb
Copy link
Contributor Author

CC @kit-ty-kate

Should I mark the previous preview release as available: false?

Copy link
Member

@kit-ty-kate kit-ty-kate left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Adding a new version should not be necessary, the point of a preview release is also to avoid having to add more packages than necessary in opam-repository. Could you instead simply upgrade the url and checksum of 0.32.1~5.2preview with that of the new commit?

@kit-ty-kate
Copy link
Member

An example of that can be found in #25322

@NathanReb
Copy link
Contributor Author

Ah yes sure, my bad!

@NathanReb NathanReb changed the title [new release] ppxlib (0.32.1~5.2preview2) Update ppxlib.0.32.1~5.2preview Mar 11, 2024
@mseri
Copy link
Member

mseri commented Mar 12, 2024

Non of the failures seem new. Can I merge or do you want to have a look at something in particular?

@NathanReb
Copy link
Contributor Author

Nothing on my side. I haven't gone through all the failures but from a quick look I agree they do seem familiar!

We would really need for opam-ci to be able to detect when a failure is actually triggered by the new release and when it's not. Having so many false positive really makes it hard and time consuming to actually find and fix real errors.

@mseri mseri merged commit f2800c5 into ocaml:master Mar 12, 2024
1 of 2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants