Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

afl-persistent 1.4: add patch to fix macos build #25144

Merged
merged 3 commits into from
Jan 31, 2024

Conversation

mseri
Copy link
Member

@mseri mseri commented Jan 31, 2024

No description provided.

@mseri
Copy link
Member Author

mseri commented Jan 31, 2024

Failure is

+ /Users/mac1000/.opam/opam-init/hooks/sandbox.sh "build" "dune" "build" "-p" "afl-persistent" "-j" "11" (CWD=/Users/mac1000/.opam/4.14.1/.opam-switch/build/afl-persistent.1.4)
Processing  4/10: [afl-persistent: ./config.sh]
+ /Users/mac1000/.opam/opam-init/hooks/sandbox.sh "build" "./config.sh" (CWD=/Users/mac1000/.opam/4.14.1/.opam-switch/build/afl-persistent.1.4)
- ./config.sh: line 17: cannot create temp file for here document: Operation not permitted
[ERROR] The compilation of afl-persistent.1.4 failed at "./config.sh".

@mseri
Copy link
Member Author

mseri commented Jan 31, 2024

The crowbar 0.2 failure is interesting:

#=== ERROR while compiling crowbar.0.2 ========================================#
# context              2.2.0~beta1 | linux/x86_64 | ocaml-base-compiler.5.1.1 | file:///home/opam/opam-repository
# path                 ~/.opam/5.1/.opam-switch/build/crowbar.0.2
# command              ~/.opam/opam-init/hooks/sandbox.sh build dune build -p crowbar -j 71 @examples/calendar/runtest @examples/fpath/runtest @examples/map/runtest @examples/serializer/runtest @examples/uunf/runtest
# exit-code            1
# env-file             ~/.opam/log/crowbar-6-7cedca.env
# output-file          ~/.opam/log/crowbar-6-7cedca.out
### output ###
# File "examples/calendar/dune", line 2, characters 7-20:
# 2 |  (name test_calendar)
#            ^^^^^^^^^^^^^
# (cd _build/default/examples/calendar && ./test_calendar.exe)
# calendar: FAIL
# 
# When given the input:
# 
#     [1995-08-31 11:32:28; 1995-12-08 12:01:19]
#     
# the test failed:
# 
#     1995-12-09 12:01:19 != 1995-12-08 12:01:19

@mseri
Copy link
Member Author

mseri commented Jan 31, 2024

But unrelated

@mseri mseri merged commit b38ea50 into ocaml:master Jan 31, 2024
1 of 2 checks passed
@mseri mseri deleted the afl-persistent branch January 31, 2024 16:07
@@ -9,6 +9,9 @@ build: [
[ "dune" "build" "-p" name "-j" jobs ]
[ "./config.sh" ]
]
patches: [
"config.patch"
]
Copy link
Member

@hannesm hannesm Jan 31, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

what is missing here is a section:

extra-files: [
  ["config.patch" "md5=<>"]
]

at least with the upcoming change in opam ocaml/opam#5564 this extra-files section is necessary...

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I like this change, thanks for pointing it out. I'll send a PR immediately.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants