-
Notifications
You must be signed in to change notification settings - Fork 1.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
new file: conf-pip-rdkit/conf-pip-rdkit.1.0.0/opam #24633
Conversation
the section x-ci-accept-failures in the opam file is left there in case the CI environment starts to annoy us |
This cannot work, the sandbox does not allow internet access or the modification of external folders :( |
Well, this is a valid opam package ! |
For a very famous dependency in my field... |
Yes but it does not to what it is meant to be doing. The package should install and check that rdkit is installed. We can skip the installation if it cannot be done, like in this case, since pip would escape opam sandbox and fail, but should have the check that the package is present. So in this form it is not really fulfilling its purpose. To support pip depext, you could suggest the feature on the ocaml/opam repository, as it was recently done for npm. Once that is in opam, we can let opam install rdkit as well in this conf package. |
Ok, I see. |
Thanks! Python is such a common requirement that I think there could be value in integrating pip with opam fwiw. Feel free to open an issue about it in the ocaml/opam repository, perhaps mention that something similar is being done for npm and could also be reasonable to think of it broader (including R and rust for example). UPDATE: I only now see you already opened the issue. Thanks! |
I am going to close this for now since it cannot work with the current sandbox limitation. I am happy to reopen-revisit this once the relevant support exists in opam |
this is the modern way to install rdkit, on most distros and operating systems