Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[new release] opam-monorepo (0.3.0) #21236

Closed
wants to merge 1 commit into from
Closed

[new release] opam-monorepo (0.3.0) #21236

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
54 changes: 54 additions & 0 deletions packages/opam-monorepo/opam-monorepo.0.3.0/opam
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,54 @@
opam-version: "2.0"
synopsis: "Assemble and manage fully vendored Dune repositories"
description: """
The opam monorepo plugin provides a convenient interface to bridge the
opam package manager with having a local copy of all the source
code required to build a project using the dune build tool."""
maintainer: ["[email protected]"]
authors: [
"Anil Madhavapeddy" "Nathan Rebours" "Lucas Pluvinage" "Jules Aguillon"
]
license: "ISC"
homepage: "https://github.com/ocamllabs/opam-monorepo"
doc: "https://ocamllabs.github.io/opam-monorepo"
bug-reports: "https://github.com/ocamllabs/opam-monorepo/issues"
depends: [
"dune" {>= "2.9"}
"ocaml" {>= "4.08.0"}
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
"ocaml" {>= "4.08.0"}
"ocaml" {>= "4.13"} 
#=== ERROR while compiling opam-monorepo.0.3.0 ================================#
# context              2.1.2 | linux/x86_64 | ocaml-base-compiler.4.12.1 | pinned(https://github.com/ocamllabs/opam-monorepo/releases/download/0.3.0/opam-monorepo-0.3.0.tbz)
# path                 ~/.opam/4.12/.opam-switch/build/opam-monorepo.0.3.0
# command              ~/.opam/opam-init/hooks/sandbox.sh build dune build -p opam-monorepo -j 31 @install
# exit-code            1
# env-file             ~/.opam/log/opam-monorepo-1976-b81551.env
# output-file          ~/.opam/log/opam-monorepo-1976-b81551.out
### output ###
# (cd duniverse/0install/src/gui_gtk && /home/opam/.opam/4.12/bin/ocaml -I +compiler-libs /home/opam/.opam/4.12/.opam-switch/build/opam-monorepo.0.3.0/_build/.dune/default/duniverse/0install/src/gui_gtk/dune.ml)
# sh: 1: ocamlfind: not found
# (will skip building the GTK plugin)
# (cd _build/default && /home/opam/.opam/4.12/bin/ocamldep.opt -modules -impl cli/lock.ml) > _build/default/cli/.duniverse_cli.objs/lock.ml.d
# File "cli/lock.ml", line 259, characters 15-17:
# 259 |       let* acc in
#                      ^^
# Error: Syntax error: operator expected.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Argh that's ocamlformat reformatting it this way. I'm afraid we'll have to abort this release and start again!

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is there an issue somewhere tracking this bug?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It is not an ocamlformat-per-se bug. It just defaults to format for the currently active OCaml version (I assume) and we didn't tell it to stay 4.08 compatible: tarides/opam-monorepo#287

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ah I see. I was unaware of the ocaml-version option

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I’m still considering this somewhat of a bug personally and I opened a PR here to avoid this issue in the future: ocaml-ppx/ocamlformat#2064

"odoc" {with-doc}
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
"odoc" {with-doc}
"odoc" {with-doc}
"conf-pkg-config"

]
conflicts: [
"dune-build-info" {= "2.7.0" | = "2.7.1"}
"dune-configurator" {= "2.7.0" | = "2.7.1"}
]
dev-repo: "git+https://github.com/ocamllabs/opam-monorepo.git"
build: [ "dune" "build" "-p" name "-j" jobs "@install" "@runtest" {with-test} ]
flags: [ plugin ]
depexts: [
["devel/pkgconf"] {os = "openbsd"}
["pkg-config"] {os-family = "debian"}
["pkg-config"] {os = "macos" & os-distribution = "homebrew"}
["pkgconf"] {os = "freebsd"}
["pkgconf"] {os-distribution = "alpine"}
["pkgconf"] {os-distribution = "arch"}
["pkgconf-pkg-config"] {os-distribution = "fedora"}
["pkgconf-pkg-config"] {os-distribution = "mageia"}
["pkgconf-pkg-config"] {os-distribution = "centos" & os-version >= "8"}
["pkgconf-pkg-config"] {os-distribution = "ol" & os-version >= "8"}
["pkgconf-pkg-config"] {os-distribution = "rhel" & os-version >= "8"}
["pkgconfig"] {os-distribution = "nixos"}
["pkgconfig"] {os = "macos" & os-distribution = "macports"}
["pkgconfig"] {os-distribution = "centos" & os-version <= "7"}
["pkgconfig"] {os-distribution = "ol" & os-version <= "7"}
["pkgconfig"] {os-distribution = "rhel" & os-version <= "7"}
["system:pkgconf"] {os = "win32" & os-distribution = "cygwinports"}
]
Comment on lines +27 to +45
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
depexts: [
["devel/pkgconf"] {os = "openbsd"}
["pkg-config"] {os-family = "debian"}
["pkg-config"] {os = "macos" & os-distribution = "homebrew"}
["pkgconf"] {os = "freebsd"}
["pkgconf"] {os-distribution = "alpine"}
["pkgconf"] {os-distribution = "arch"}
["pkgconf-pkg-config"] {os-distribution = "fedora"}
["pkgconf-pkg-config"] {os-distribution = "mageia"}
["pkgconf-pkg-config"] {os-distribution = "centos" & os-version >= "8"}
["pkgconf-pkg-config"] {os-distribution = "ol" & os-version >= "8"}
["pkgconf-pkg-config"] {os-distribution = "rhel" & os-version >= "8"}
["pkgconfig"] {os-distribution = "nixos"}
["pkgconfig"] {os = "macos" & os-distribution = "macports"}
["pkgconfig"] {os-distribution = "centos" & os-version <= "7"}
["pkgconfig"] {os-distribution = "ol" & os-version <= "7"}
["pkgconfig"] {os-distribution = "rhel" & os-version <= "7"}
["system:pkgconf"] {os = "win32" & os-distribution = "cygwinports"}
]

url {
src:
"https://github.com/ocamllabs/opam-monorepo/releases/download/0.3.0/opam-monorepo-0.3.0.tbz"
checksum: [
"sha256=82e8241a5ff0e82cbbff28f1a41e77adc92bb544f62d5eb9ba6e7842e75a7e5c"
"sha512=3bb39cdaa257e22744b4349a0788286943fb47997d2e79f52c7497f936998f08e87d33e3637f58b62589cf4ef2c6b3547bbd66208e3c48085a1776fef59f5bbf"
]
}
x-commit-hash: "268f77993146d83951dbc139147dc801cea8517c"