-
Notifications
You must be signed in to change notification settings - Fork 1.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Proposal] Add previews of some of the platform packages with OCaml 4.13 compatibility #18825
Conversation
Sounds good to me. |
Superb, thanks @kit-ty-kate! In the interests of longer term reproducibility, how about replacing the git branches with explicit sha256 changesets instead? This'll be a little more work for us to maintain, but in return those packages will build into the longer term with just a checkout of opam-repository. |
Thanks @kit-ty-kate! For OMP2 that sounds good to me. For
It will still depend on OMP2 and it isn't implemented yet, but we can re-use one of your commits (thanks for separating them!). |
Thinking about this more:
I think merging just the branches as they are in this PR is fine, and then "freeze" them to sha256 changesets when we release 4.13 and mark the package as unavailable. That'll preserve the history but not make day-to-day development a pain. |
a5de63e
to
7980cbc
Compare
I've removed OMP from the PR as it was properly released with OCaml 4.13 support yesterday in #18902 |
c7c7199
to
5b84634
Compare
@Octachron @jonludlam this appears to be failing on 4.13...
|
This failure is in |
This should work after #18977 is merged |
5b84634
to
ae16a36
Compare
Given the rest of the packages were all released and ppxlib.0.23.0 is not necessary anymore I've updated this PR to include ocamlformat, mdx and odoc (1.5 branch, instead of 2.0) Are the proposed version numbers what they are expected to be when the support for OCaml 4.13 is going to be included? |
The version number for ocamlformat is correct indeed (0.19.0), I just merged the 4.13 support by the way. The release is expected before July 16th. |
This PR copies some of the platforms packages from https://github.com/kit-ty-kate/opam-alpha-repository/ to make OCaml 4.13 simpler to test for people.
Proposal
This PR adds a preview of the next version of
ocamlformat
,odoc
andmdx
namely:ocamlformat.0.19.0~4.13preview
odoc.1.5.3~4.13preview
mdx.1.11.0~4.13preview
For the moment they point to specific git branches to make them support OCaml 4.13. They all have their corresponding PRs or are already merged in their main branch (see #18791 for details)
The goal is to update the package and the branch as the alpha/beta cycle progresses (there should only be one version of these preview packages at all time, no
~4.13preview2
and whatnot), and once the proper release for them land, we can simply mark it asavailable: false
and forget about the previews.This version number scheme should allow you to still release alpha/beta/rc versions and let them be taken first above those preview packages. It also allows us to be more explicit about what this version is (a simple preview of this package's next version with OCaml 4.13 support)
In parallel, those packages will also be available in opam-alpha-repository but marked available with the older stable versions of the compiler for more broad testing purpose.
cc @jonludlam for odoc
cc @NathanReb @emillon for mdx
cc @gpetiot @emillon for ocamlformat
What are your (package maintainers) views on this? Are the proposed version numbers the correct one for the next release?