Remove dependency cycles

[samoht]

No description provided.

[samoht]

This makes opam admin check --cycle --ignore-test-doc return without error.

[samoht]

It's probably not worth testing the revdpes on the entiere universe. @dra27 and @kit-ty-kate are you ok to merge this?

[camelus]

Commit: 019b3aa

A pull request by opam-seasoned @samoht.

🌤️ opam-lint warnings 019b3aa

• ocamlfind-secondary.1.8.1 has some warnings:

  • warning 37: Missing field 'dev-repo'
  • warning 47: Synopsis (or description first line) should start with a capital and not end with a dot

• These packages passed lint tests: dune-configurator.2.7.1, dune-configurator.2.8.0, dune-configurator.2.8.1, dune-configurator.2.8.2, fileutils.0.6.0, graphics.5.0.0

---

☀️ Installability check (+0)

[kit-ty-kate]

What was the issue here? I'd rather have the constraint in the correct file (dune-configurator) rather than here. It's much easier to understand and maintain this way.

[kit-ty-kate]

same question here. Something tells me the constraint should be in ocamlfind-secondary.

[samoht]

@kit-ty-kate there is a cycle between these packages which confuses the solver:

dune (>= 2.0.0 & < 2.1.1) -> ocamlfind-secondary = 1.8.1 -> ocamlfind = 1.8.1 -> graphics = 5.0.0

This PR breaks that cycle explicitly by adding a conflict in the middle of the dependency chain. That same conflict can be added either in dune or ocamlfind or grapics but not in ocamlfind-secondary as it's not part of the chain. I can add a comment in the file to make that clearer if you think that's useful.

[samoht]

@kit-ty-kate I've fixed the location of the graphics constraint ; for the result one it's easier to patch the old result.1.3. than all the existing (and future) release of dune-configurator. Is that ok with you?

[samoht]

The revdep testing are killing the CI. @kit-ty-kate is this ok if I merge this quickly?

[kit-ty-kate]

This PR might not be necessary as opam admin check --cycle might not take coinstallability into account according to @AltGr. I suggest to not merge until we know more.
Opam issue: ocaml/opam#4541

[samoht]

Closing as it needs caml/opam#4541 to be resolved first.