Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update pkg-config system package name for rhel and centos 8 and above #16333

Merged
merged 1 commit into from
May 2, 2020
Merged

update pkg-config system package name for rhel and centos 8 and above #16333

merged 1 commit into from
May 2, 2020

Conversation

bikallem
Copy link
Contributor

@bikallem bikallem commented May 1, 2020

Fixes #16332

@bikallem
Copy link
Contributor Author

bikallem commented May 1, 2020

This should now allow those on ocaml 4.09 and above to be able to install graphics package correctly.

@camelus
Copy link
Contributor

camelus commented May 1, 2020

Commit: 064b97b

@bikallem has posted 3 contributions.

🌩️ opam-lint errors 064b97b
  • conf-pkg-config.1.2 has errors:

    • error 46: Package is flagged "conf" but has source, install or remove instructions

☀️ Installability check (+1)
  • new installable packages (1): conf-pkg-config.1.2

@kit-ty-kate
Copy link
Member

For our own record, here is the difference between conf-pkg-config.1.1 and conf-pkg-config.1.2:

--- opam.1.1	2020-04-03 15:22:16.796495179 +0100
+++ opam.1.2	2020-05-02 13:03:29.079536186 +0100
@@ -20,15 +20,17 @@
   ["pkg-config"] {os-family = "debian"}
   ["pkg-config"] {os-distribution = "arch"}
   ["pkgconfig"] {os-distribution = "fedora"}
-  ["pkgconfig"] {os-distribution = "centos"}
+  ["pkgconfig"] {os-distribution = "centos" & os-version <= "7"}
   ["pkgconfig"] {os-distribution = "mageia"}
-  ["pkgconfig"] {os-distribution = "rhel"}
+  ["pkgconfig"] {os-distribution = "rhel" & os-version <= "7"}
   ["pkgconfig"] {os-distribution = "ol"}
   ["pkgconfig"] {os-distribution = "alpine"}
   ["pkgconfig"] {os-distribution = "nixos"}
   ["devel/pkgconf"] {os = "openbsd"}
   ["pkg-config"] {os = "macos" & os-distribution = "homebrew"}
   ["pkgconf"] {os = "freebsd"}
+  ["pkgconf-pkg-config"] {os-distribution = "rhel" & os-version >= "8"}
+  ["pkgconf-pkg-config"] {os-distribution = "centos" & os-version >= "8"}
   ["pkg-config"] {os-distribution = "cygwinports"}
 ]
 synopsis: "Virtual package relying on pkg-config installation"

Thanks!

@kit-ty-kate kit-ty-kate merged commit 4ea5f77 into ocaml:master May 2, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

unable to install conf-pkg-config in Red Hat Linux 8
3 participants