Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

curly: requires alcotest for tests #14193

Merged
merged 3 commits into from
Jun 7, 2019
Merged

Conversation

avsm
Copy link
Member

@avsm avsm commented May 27, 2019

No description provided.

@camelus
Copy link
Contributor

camelus commented May 28, 2019

☀️ All lint checks passed ac89142
  • These packages passed lint tests: curly.0.1.0

☀️ Installability check (11241 → 11241)

@kit-ty-kate
Copy link
Member

A dependency to an old version of lwt seems required for tests:

#=== ERROR while compiling curly.0.1.0 ========================================#
# context     2.0.3 | linux/x86_64 | ocaml-base-compiler.4.07.1 | file:///home/travis/build/ocaml/opam-repository
# path        ~/.opam/ocaml-base-compiler.4.07.1/.opam-switch/build/curly.0.1.0
# command     ~/.opam/opam-init/hooks/sandbox.sh build jbuilder runtest -p curly -j 1
# exit-code   1
# env-file    ~/.opam/log/curly-16595-4847c3.env
# output-file ~/.opam/log/curly-16595-4847c3.out
### output ###
# [...]
# Note: You can use "dune upgrade" to convert your project to dune.
# File "src/jbuild", line 1, characters 0-0:
# Warning: jbuild files are deprecated, please convert this file to a dune file instead.
# Note: You can use "dune upgrade" to convert your project to dune.
# File "test/jbuild", line 1, characters 0-0:
# Warning: jbuild files are deprecated, please convert this file to a dune file instead.
# Note: You can use "dune upgrade" to convert your project to dune.
# File "test/jbuild", line 5, characters 45-59:
# 5 |   (libraries (curly alcotest cohttp-lwt-unix lwt.preemptive))))
#                                                  ^^^^^^^^^^^^^^
# Error: Library "lwt.preemptive" not found.
# Hint: try: dune external-lib-deps --missing -j 1 -p curly @runtest

@kit-ty-kate
Copy link
Member

arf I forgot to merge this one. Thanks!

@kit-ty-kate kit-ty-kate merged commit 600e82e into ocaml:master Jun 7, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants