Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

easy-format 1.3.0, now uses jbuilder #10048

Merged
merged 2 commits into from
Aug 12, 2017
Merged

easy-format 1.3.0, now uses jbuilder #10048

merged 2 commits into from
Aug 12, 2017

Conversation

mjambon
Copy link
Contributor

@mjambon mjambon commented Aug 7, 2017

No description provided.

@camelus
Copy link
Contributor

camelus commented Aug 7, 2017

✅ All lint checks passed 8b27ae2
  • These packages passed lint tests: easy-format.1.3.0

✅ Installability check (7226 → 7227)
  • new installable packages (1): easy-format.1.3.0

@rgrinberg
Copy link
Member

Hi @mjambon . I believe you need to rename the current opam file in this PR and rename easy-format.opam to opam.

@avsm
Copy link
Member

avsm commented Aug 9, 2017

There are some reverse dependency failures coming up from this, or possibly from a cppo upgrade:

#=== ERROR while compiling bisect_ppx.1.2.0 ===================================#
# context              2.0.0~beta3 | linux/x86_64 | ocaml-base-compiler.4.04.2 | file:///home/opam/src
# path                 ~/.opam/ocaml-base-compiler.4.04.2/.opam-switch/build/bisect_ppx.1.2.0
# command              make build
# exit-code            2
# env-file             ~/.opam/log/bisect_ppx-78-548b09.env
# output-file          ~/.opam/log/bisect_ppx-78-548b09.out
### output ###
# ocamlbuild -use-ocamlfind -no-links -byte-plugin -plugin-tag 'package(cppo_ocamlbuild)'  src/syntax/bisect_ppx.native  src/report/report.native src/bisect.cma src/bisect.cmxa  src/ocamlbuild/bisect_ppx_plugin.cma  src/ocamlbuild/bisect_ppx_plugin.cmxa
# ocamlfind ocamlc -package unix -package ocamlbuild -linkpkg -package cppo_ocamlbuild myocamlbuild.ml /home/opam/.opam/ocaml-base-compiler.4.04.2/lib/ocamlbuild/ocamlbuild.cmo -o myocamlbuild
# + ocamlfind ocamlc -package unix -package ocamlbuild -linkpkg -package cppo_ocamlbuild myocamlbuild.ml /home/opam/.opam/ocaml-base-compiler.4.04.2/lib/ocamlbuild/ocamlbuild.cmo -o myocamlbuild
# ocamlfind: Package `cppo_ocamlbuild' not found
# Command exited with code 2.
# Makefile:99: recipe for target 'build' failed
# make: *** [build] Error 10

@rgrinberg
Copy link
Member

There are some reverse dependency failures coming up from this, or possibly from a cppo upgrade:

Good catch. cppo_ocamlbuild is now a separate package and needs to be submitted as well. The failed packages need their dependencies updated.

@rgrinberg
Copy link
Member

@avsm where can i see the list of rev deps that failed to build?

@avsm
Copy link
Member

avsm commented Aug 10, 2017

This is continued in #10047

@rgrinberg
Copy link
Member

@avsm Why does this need maintainer action? I think this is safe to merge and has nothing to do with the cppo_ocamlbuild packaging change.

@avsm
Copy link
Member

avsm commented Aug 12, 2017

This does looks fine, thanks!

@avsm avsm merged commit 62a7d51 into ocaml:master Aug 12, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants