Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Package for ocaml-imagemagick #44

Closed
venator opened this issue Sep 14, 2012 · 6 comments
Closed

Package for ocaml-imagemagick #44

venator opened this issue Sep 14, 2012 · 6 comments

Comments

@venator
Copy link
Contributor

venator commented Sep 14, 2012

http://www.linux-nantes.org/~fmonnier/ocaml/ImageMagick/

@vbmithr
Copy link
Contributor

vbmithr commented Sep 18, 2012

This package does not compile for me:

[vb@nerenyi ~/Downloads/OCaml-ImageMagick-0.33]% LC_ALL=C make
ocamlmklib -o imagemagick_stubs imagemagick_wrap.o imagemagick_list.o
-lMagickCore
/usr/bin/ld: imagemagick_wrap.o: relocation R_X86_64_32 against `finalize_image' can not be used when making a shared object; recompile with -fPIC
imagemagick_wrap.o: could not read symbols: Bad value
collect2: error: ld returned 1 exit status
make: *** [dllimagemagick_stubs.so] Error 2

@hhugo
Copy link
Contributor

hhugo commented Sep 18, 2012

Hello,

We did some fixes here :
https://github.com/besport/ocaml-imagemagick

I'm not sure it will fix you issue ..

On Tue, Sep 18, 2012 at 1:39 AM, Vincent Bernardoff <
[email protected]> wrote:

This package does not compile for me:

[vb@nerenyi ~/Downloads/OCaml-ImageMagick-0.33]% LC_ALL=C make
ocamlmklib -o imagemagick_stubs imagemagick_wrap.o imagemagick_list.o
-lMagickCore

/usr/bin/ld: imagemagick_wrap.o: relocation R_X86_64_32 against
`finalize_image' can not be used when making a shared object; recompile
with -fPIC
imagemagick_wrap.o: could not read symbols: Bad value
collect2: error: ld returned 1 exit status
make: *** [dllimagemagick_stubs.so] Error 2


Reply to this email directly or view it on GitHubhttps://github.com/OCamlPro/opam-repository/issues/44#issuecomment-8645453.

@vbmithr
Copy link
Contributor

vbmithr commented Sep 19, 2012

On 19/09/2012 00:58, hhugo wrote:

Hello,

We did some fixes here :
https://github.com/besport/ocaml-imagemagick

I'm not sure it will fix you issue ..

It did, thank you very much. Could you please add a tag for this version
in your ocaml-imagemagick github repo ? We’re a bit reluctant to include
untagged git packages in opam, because they might stop working at some
point if you update the git repo and something goes wrong.

I’ll add the package in OPAM repository as soon as its done, thanks!

Vincent.

@hhugo
Copy link
Contributor

hhugo commented Sep 21, 2012

I just did push the tag "0.33" on the repo.

Also, I have an other package request : ocaml-leveldb
git://github.com/mfp/ocaml-leveldb.git (mainstream)
git://github.com/besport/ocaml-leveldb.git (few patches to make it work
with native dynlink)

Hugo

On Wed, Sep 19, 2012 at 1:32 AM, Vincent Bernardoff <
[email protected]> wrote:

On 19/09/2012 00:58, hhugo wrote:

Hello,

We did some fixes here :
https://github.com/besport/ocaml-imagemagick

I'm not sure it will fix you issue ..

It did, thank you very much. Could you please add a tag for this version
in your ocaml-imagemagick github repo ? We’re a bit reluctant to include
untagged git packages in opam, because they might stop working at some
point if you update the git repo and something goes wrong.

I’ll add the package in OPAM repository as soon as its done, thanks!

Vincent.


Reply to this email directly or view it on GitHubhttps://github.com/OCamlPro/opam-repository/issues/44#issuecomment-8684193.

@samoht
Copy link
Member

samoht commented Sep 21, 2012

we happily accept pull requests for new packages :-) There is a nice tutorial here: http://opam.ocamlpro.com/doc/Packaging.html

@vbmithr
Copy link
Contributor

vbmithr commented Sep 21, 2012

Hugo: I’ll happily make the packages for the mentionned software, but same story, I’d like to have these tagged.
Otherwise, you can just make "git" packages (leveldb.0) and add them to a private repository that you use internally at besport (or just yourself). I guess I really have to write that "developping with OPAM" tutorial :D

@samoht samoht closed this as completed in 6625c78 Sep 21, 2012
samoht added a commit that referenced this issue Sep 21, 2012
Added package for ImageMagick, fix #44
NathanReb pushed a commit to NathanReb/opam-repository that referenced this issue Nov 26, 2021
NathanReb pushed a commit to NathanReb/opam-repository that referenced this issue Nov 26, 2021
xavierleroy added a commit to xavierleroy/opam-repository that referenced this issue Oct 23, 2024
- ocaml#44: tolerate ZIP entries that are marked "deflated" but have size 0
  [Antoine Provot]
- ocaml#46: provide `Zip.open_update` to add entries to an existing ZIP file
- ocaml#47: in `Zlib.inflate`, detect and fail on truncated input instead of looping
- ocaml#48: under Windows, store file names in ZIP entries using forward slashes `/`
  instead of backslashes `\`
xavierleroy added a commit to xavierleroy/opam-repository that referenced this issue Oct 24, 2024
- ocaml#44: tolerate ZIP entries that are marked "deflated" but have size 0
  [Antoine Provot]
- ocaml#46: provide `Zip.open_update` to add entries to an existing ZIP file
- ocaml#47: in `Zlib.inflate`, detect and fail on truncated input instead of looping
- ocaml#48: under Windows, store file names in ZIP entries using forward slashes `/`
  instead of backslashes `\`
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants