Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

cleaned up redirection urls #1969

Merged
merged 3 commits into from
Jan 29, 2024
Merged

cleaned up redirection urls #1969

merged 3 commits into from
Jan 29, 2024

Conversation

0xGlitchbyte
Copy link
Contributor

@0xGlitchbyte 0xGlitchbyte commented Jan 18, 2024 •
edited
Loading

I changed the redirection links for:

  • data-types to basic-data-types

I removed files redirects for:

  • functional-programming
  • modules
  • null-pointers-asserts-and-warnings
  • pointers
  • streams

This PR closes the issue Check tutorial redirection rules #1959

@0xGlitchbyte 0xGlitchbyte marked this pull request as ready for review January 18, 2024 12:42
cuihtlauac
cuihtlauac requested changes Jan 18, 2024
View reviewed changes
Copy link
Collaborator

@cuihtlauac cuihtlauac left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, @0xGlitchbyte, this is great. Why did you remove the rules on modules?

src/ocamlorg_web/lib/redirection.ml Outdated Show resolved Hide resolved
@sabine
Copy link
Collaborator

sabine commented Jan 29, 2024

Thanks @0xGlitchbyte! ✨ 👍

@sabine sabine merged commit b8a7e7f into ocaml:main Jan 29, 2024
2 of 3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cuihtlauac cuihtlauac cuihtlauac approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@0xGlitchbyte @sabine @cuihtlauac