Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add test for issue #1575 Completion for OCaml object methods #1576

Closed
wants to merge 1 commit into from
Closed

Add test for issue #1575 Completion for OCaml object methods #1576

wants to merge 1 commit into from

Conversation

sidkshatriya
Copy link
Contributor

See #1575

@sidkshatriya sidkshatriya mentioned this pull request Mar 6, 2023
Closed
@voodoos
Copy link
Collaborator

voodoos commented Mar 6, 2023 •
edited
Loading

Thanks for the test !

@voodoos
Copy link
Collaborator

voodoos commented Mar 6, 2023

If you are curious and have some tome to investigate yourself here are a few pointers:

  • You can add -log-file - in your test command to print enable logging to stderr
  • You can start investigating at Complete_prefix in the Query_commands module line 403
  • dune build @issue1575 --watch should give you some useful live feedback

Anyway I will probably have a look next week.

@voodoos voodoos mentioned this pull request May 16, 2023
Merged
@voodoos
Copy link
Collaborator

voodoos commented May 16, 2023

Closing. This test is now part of another PR with a fix: #1606

@voodoos voodoos closed this May 16, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@sidkshatriya @voodoos