Skip to content

Commit

Permalink
Add comment about cache misses on trivial changes
Browse files Browse the repository at this point in the history
  • Loading branch information
pitag-ha committed May 12, 2023
1 parent cfb2fed commit 88744e1
Showing 1 changed file with 3 additions and 0 deletions.
3 changes: 3 additions & 0 deletions src/kernel/mpipeline.ml
Original file line number Diff line number Diff line change
Expand Up @@ -272,6 +272,9 @@ let process
if config.merlin.use_ppx_cache then None
else Some "configuration"
in
(* With this, the cache is invalidated even for source changes that don't
change the parsetree. To avoid that, we'd have to digest the parsetree
in the cache. *)
let force_invalidation = not source_is_unmodified in
Ppx_with_cache.apply ~cache_disabling ~force_invalidation {parsetree; config}
in
Expand Down

0 comments on commit 88744e1

Please sign in to comment.